vscode-typescript-language-features does not include typescript-vscode-sh-plugin

[tsmaeder]

The typescript language features built-in (I tried with 1.49.3) requires a plugin for the typescript language server. When looking at the tsserver log, it ties to load the module 'typescript-vscode-sh-plugin' and fails. Not clear what the consequences of the failure are. Doc (see https://github.com/aeschli/typescript-vscode-sh-plugin) indicates the plugin provides better semantic coloring.
The plugin is referenced in https://github.com/microsoft/vscode/blob/924ccf2b63b6841b09ed8e3b26362cf38a558d3a/extensions%2Ftypescript-language-features%2Fpackage.json and https://github.com/microsoft/vscode/blob/844f49f2a873bda53891bceb4ccc86bd631cfcbd/extensions%2Ftypescript-language-features%2Fextension.webpack.config.js

In particular, there is an "externals" field in the webpack config. Maybe we should process this config for all built-ins?

The module ends up in the extensions folder under <extension root dir>/node_modules/typescript-vscode-sh-plugin in vscode.

[marcdumais-work]

The module ends up in the extensions folder under <extension root dir>/node_modules/typescript-vscode-sh-plugin in vscode.

i had a look and pre-packaging, that folder is present.

vscode-builtin-extensions$ ls -al vscode-builtin-extensions/extensions/typescript-language-features/node_modules/
total 12
drwxr-xr-x 3 lmcmcds eusers 4096 Feb 11 19:22 .
drwxr-xr-x 6 lmcmcds eusers 4096 Feb 11 19:56 ..
drwxr-xr-x 4 lmcmcds eusers 4096 Feb 11 19:22 typescript-vscode-sh-plugin

So, for some reason, vsce does not keep this is the packaged extension, when we run vsce package on it

It could be that it's removed since considered external by webpack, which I assume to mean something like "do not worry this dep will be present somehow at runtime"
update: the webpack configs are no longer present in out built extensions folder, so I assume webpack has done its job by the time we package.