Workspace.findFiles don't works

[frank-dspeed]

Description

when opening a large project lets say a linuxRootFs search in folders or any other search returns no results on any pattern

Reproduction Steps

OS and Theia version:
theia next docker
Diagnostics:

[vnfedotov]

Is there any chance of getting this fixed? It seems to affect workspaceContains activation event for plugins -- it doesn't fire in theia, while working fine in vscode. I've narrowed it down to workspace.findFiles that returns different results in theia, compared to vscode. It's a fairly basic C project with some build artifacts, file count is 361, so it's not even that big.

[vince-fugnitto]

Is there any chance of getting this fixed?

@vnfedotov if you're interested, please feel free to provide a pull-request to address the issue.

[vnfedotov]

@vince-fugnitto I'll look into it. Its FileSearchServiceImpl, is it?

[vnfedotov]

@vince-fugnitto I think i've figured it out, but in my case it's a different issue related to ripgrep options, I've opened a new issue: #8669

[chroberino]

I am also having troubles with findFiles using Theia 1.53.2.

It looks like the vscode.workspace.findFiles() function in Theia respects .gitignore entries, which prevents files ignored by Git from being found by the function. This differs from VS Code, where findFiles() does not exclude files in .gitignore by default, leading to inconsistencies between the two environments.

[msujew]

I've submitted a PR to fix this. See #14365.

[msujew]

@chroberino Thanks for looking into it. Can you supply us with a git repo or something that reproduces this issue (and ideally the respective arguments for the findFiles call)? I cannot reproduce this, see discussion over in #14365.