Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to rebind WebSocketConnectionSource #13376

Closed
BrightKn1ght opened this issue Feb 12, 2024 · 0 comments
Closed

Unable to rebind WebSocketConnectionSource #13376

BrightKn1ght opened this issue Feb 12, 2024 · 0 comments

Comments

@BrightKn1ght
Copy link

We derived our own IDE from the theia project version 1.34.4. As one of our adaptions we added an authentication token between the browser and the theia backend based on bearer tokens.

We extended from WebSocketConnectionProvider and have overriden the function createWebSocket to inject an auth token:
our_adaption

We created our own theia plugin called theia-tiger which was able to rebind the existing WebSocketConnectionProvider with our adapted class AuthConnectionProvider before the class was constructed. At the start() method just our AuthConnectionProvider was loaded:
theia1 34 4

After PR #13082 the WebSocketConnectionProvider was replaced with WebSocketConnectionSource and also its instantiation time is now different:
theia1 46 1

Our plugin theia-tiger loads later and is not able to rebind the already created socket:
too_late

I'm not an inversify expert. I would have the follwing questions:

  1. Would it be possible with some inversify magic to still rebind the WebSocketConnectionProvider in our theia-tiger plugin?
  2. If not how would you suggest to add an auth token to the browsers socket in the current release 1.46.1?

Thanks for your help!

Additional Information

  • Operating System:

  • Theia Version: 1.46.1

@eclipse-theia eclipse-theia locked and limited conversation to collaborators Feb 12, 2024
@msujew msujew converted this issue into discussion #13377 Feb 12, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant