Pull request 1287 makes PluginSharedStyle.toIconClass() not work in some cases #13310
Comments
|
Hey @jcortell68, yes I am aware of that and this issue has been resolved by #13101 which is included in Theia 1.45.0. Can you try using that to see whether it resolves the issues you were experiencing? |
|
Ahh. Glad I asked. Let me see if the change fixes it in my situation. |
|
Bingo! It sure does. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@msujew Are you aware of any regression caused by this pull request of yours, 12827 ?
The addition of
::beforeto the selector name causes the resulting icon class to not have effect in some cases. The icon isn't shown. I ran into this with my app. Creating a standalone reproducible case will take some effort. Before I dive into that, I want to make sure that you're not already aware of the issue.Bug Description:
TBD
Steps to Reproduce:
TBD
Additional Information
The text was updated successfully, but these errors were encountered: