-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native file info fragment for Windows on Arm64 (WoA) platform. #1351
Native file info fragment for Windows on Arm64 (WoA) platform. #1351
Conversation
The following new fragment for WoA is added to the project to support local file info access using native code: org.eclipse.core.filesystem.win32.aarch64 To manually build the file info native library for WoA, on a WoA box, run the following commands: cd resources\bundles\org.eclipse.core.filesystem\natives\win32 make.bat and the following native library file for WoA is generated and saved in its relevant directory: resources\bundles\org.eclipse.core.filesystem.win32.aarch64\os\win32\aarch64\localfile_1_0_0.dll The existing 'make.bat' file mentioned above has been modified to generate correct binary for the current build environment (x64 or aarch64.)
Thank you @chirontt for this one. |
I agree that @iloveeclipse 's numbers are better than any numbers I could have produced myself. So I'll drop this PR to draft, pending closing it off later if necessary.
Not sure whether those small changes would even be needed, but I'll create a separate PR for them if needed. |
I inspected the default Line 45 in 15c6f84
As already mentioned in #1350 (comment), I think we should evaluate an JNA based implementation as an intermediate solution until we can use FFM in order to avoid more compiled native binaries. |
Yes, I agree with the JNA route; or perhaps we should start learning about FFM and skip the JNA instead. |
I would love to skip JNA and would go directly to FFM, but I assume it will take some time until the eclipse-platform requires a Java version with that we can use it. When I had some discussion about using preview-features not everybody agreed. |
I just created a PR to the clean-up all the native code and its scripts for the Windows native filesystem access: |
Just created #1422 to speed up the File-System access without native code. |
Just run the benchmark on the working implementation and it showed that the enhanced
FYI, I did that as part of #1416. |
Now that #1422 is submitted, this should not be necessary anymore. With that I think this is obsolete, but nevertheless thank you for this. Btw. it would be nice to know if #1422 makes a noticeable difference with Windows on ARM? Can you download the upcoming I-build and report back? |
I've used the Eclipse SDK for Windows on Arm64 from the latest I-build, but I don't notice much difference compared to other previous builds. |
The following new fragment for WoA is added to the project to support local file info access using native code:
To manually build the file info native library for WoA, on a WoA box, run the following commands:
cd resources\bundles\org.eclipse.core.filesystem\natives\win32 make.bat
and the following native library file for WoA is generated and saved in its relevant directory:
The existing 'make.bat' file mentioned above has been modified to generate correct binary for the current build environment (x64 or aarch64.)
As discussed here.