Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing SWT for Windows on Arm64 (WoA) fragment #1311

Merged

Conversation

chirontt
Copy link
Contributor

@chirontt chirontt commented Apr 14, 2024

Add missing SWT for Windows on Arm64 (WoA) fragment to the compare win32 plug-in.

@HannesWell
Copy link
Member

HannesWell commented May 9, 2024

Because of the discussion in eclipse-platform/eclipse.platform.releng.aggregator#577 (comment), can you please split this into multiple PRs, one for the addition of a org.eclipse.core.filesystem.win32.aarch64 and one for a org.eclipse.core.resources.win32.aarch64 so that we can discuss them separately?

The change of org.eclipse.compare.win32/META-INF/p2.inf can be applied now, so having that in a third PR would allow us to land it immediately.

@chirontt chirontt marked this pull request as draft May 10, 2024 03:17
@chirontt chirontt changed the title Add support for Windows on Arm64 (WoA) platform build. Add missing SWT for Windows on Arm64 (WoA) fragment May 10, 2024
@chirontt
Copy link
Contributor Author

chirontt commented May 10, 2024

The change of org.eclipse.compare.win32/META-INF/p2.inf can be applied now, so having that in a third PR would allow us to land it immediately.

Yeah, I'm re-making this PR to be the third one of the three PRs.

@chirontt chirontt marked this pull request as ready for review May 10, 2024 03:47
Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you.
But when reading through Bug 361901 I wonder if that p2.inf file is even necessary at all?
The SWT host bundle already has something like that so I actually wouldn't expect that to be necessary again?
@merks can you tell better?

Nevertheless I'll submit this now and we can still remove the entire file later if we conclude that it's obsolete.

Copy link
Contributor

Test Results

 1 723 files   -  8   1 723 suites   - 8   1h 23m 31s ⏱️ - 8m 41s
 4 004 tests ± 0   3 982 ✅ ± 0   22 💤 ±0  0 ❌ ±0 
12 531 runs   - 78  12 371 ✅  - 77  160 💤  - 1  0 ❌ ±0 

Results for commit cfe8c2f. ± Comparison against base commit 0aa429c.

@merks
Copy link
Contributor

merks commented May 14, 2024

I imagine each separate host bundle can benefit from filtered requirements on the known fragments. Without this, one must rely on some feature encoding those requirements or replicating them somewhere downstream.

@HannesWell HannesWell merged commit a2168a9 into eclipse-platform:master May 14, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants