-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing SWT for Windows on Arm64 (WoA) fragment #1311
Add missing SWT for Windows on Arm64 (WoA) fragment #1311
Conversation
51d7326
to
e3e71ac
Compare
Because of the discussion in eclipse-platform/eclipse.platform.releng.aggregator#577 (comment), can you please split this into multiple PRs, one for the addition of a The change of |
e3e71ac
to
0074265
Compare
Yeah, I'm re-making this PR to be the third one of the three PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you.
But when reading through Bug 361901 I wonder if that p2.inf file is even necessary at all?
The SWT host bundle already has something like that so I actually wouldn't expect that to be necessary again?
@merks can you tell better?
Nevertheless I'll submit this now and we can still remove the entire file later if we conclude that it's obsolete.
to the compare win32 plug-in.
0074265
to
cfe8c2f
Compare
I imagine each separate host bundle can benefit from filtered requirements on the known fragments. Without this, one must rely on some feature encoding those requirements or replicating them somewhere downstream. |
Add missing SWT for Windows on Arm64 (WoA) fragment to the compare win32 plug-in.