Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Failure of org.eclipse.debug.tests.console.RuntimeProcessTests.testProcessTerminated #863

Closed
fedejeanne opened this issue Nov 16, 2023 · 2 comments
Closed

[Windows] Failure of org.eclipse.debug.tests.console.RuntimeProcessTests.testProcessTerminated #863

fedejeanne opened this issue Nov 16, 2023 · 2 comments
Labels
help wanted Extra attention is needed test junit test related things Windows Happens on Windows OS

Comments

@fedejeanne
Copy link
Contributor

It failed in this Windows build of #862

org.eclipse.debug.tests.console.RuntimeProcessTests.testProcessTerminated -- Time elapsed: 1.138 s <<< FAILURE!
java.lang.AssertionError: RuntimePocess not terminated.
	at org.junit.Assert.fail(Assert.java:89)
	at org.eclipse.debug.tests.TestUtil.waitWhile(TestUtil.java:138)
	at org.eclipse.debug.tests.console.RuntimeProcessTests.testProcessTerminated(RuntimeProcessTests.java:67)
...
@fedejeanne fedejeanne mentioned this issue Nov 16, 2023
Merged
@HeikoKlare HeikoKlare mentioned this issue Nov 29, 2023
Merged
@fedejeanne fedejeanne added help wanted Extra attention is needed Windows Happens on Windows OS test junit test related things labels Dec 8, 2023
@HeikoKlare
Copy link
Contributor

The problem affects multiple tests in RuntimeProcessTests. They are failing quite often recently, e.g., https://github.com/eclipse-platform/eclipse.platform/actions/runs/7145955687/job/19463184753

testTerminateProcessWithSubProcesses (org.eclipse.debug.tests.console.RuntimeProcessTests):

RuntimePocess not terminated.
java.lang.AssertionError: RuntimePocess not terminated.
	at org.junit.Assert.fail(Assert.java:89)
	at org.eclipse.debug.tests.TestUtil.waitWhile(TestUtil.java:138)
	at org.eclipse.debug.tests.console.RuntimeProcessTests.testTerminateProcessWithSubProcesses(RuntimeProcessTests.java:132)

testProcessTerminated (org.eclipse.debug.tests.console.RuntimeProcessTests):

RuntimePocess not terminated.
java.lang.AssertionError: RuntimePocess not terminated.
	at org.junit.Assert.fail(Assert.java:89)
	at org.eclipse.debug.tests.TestUtil.waitWhile(TestUtil.java:138)
	at org.eclipse.debug.tests.console.RuntimeProcessTests.testProcessTerminated(RuntimeProcessTests.java:67)

HeikoKlare added a commit to HeikoKlare/eclipse.platform that referenced this issue Dec 18, 2023
@HeikoKlare
Use common timeout for RuntimeProcessTests eclipse-platform#863
c456a70 
The test methods of RuntimeProcessTests use different and rather low
timeout values. Depending on the execution environment, the timeouts may
be exceeded and could be a reason for random failures of these tests.

The change replaces all custom timeout values with the common timeout
already defined in AbstractDebugTest.

Contributes to
eclipse-platform#863
@HeikoKlare HeikoKlare mentioned this issue Dec 18, 2023
Merged
HeikoKlare added a commit that referenced this issue Dec 18, 2023
@HeikoKlare
Use common timeout for RuntimeProcessTests #863
c2165a3 
The test methods of RuntimeProcessTests use different and rather low
timeout values. Depending on the execution environment, the timeouts may
be exceeded and could be a reason for random failures of these tests.

The change replaces all custom timeout values with the common timeout
already defined in AbstractDebugTest.

Contributes to
#863
Michael5601 pushed a commit to CodeLtDave/eclipse.platform that referenced this issue Feb 12, 2024
@HeikoKlare @Michael5601
Use common timeout for RuntimeProcessTests eclipse-platform#863
1ea245c 
The test methods of RuntimeProcessTests use different and rather low
timeout values. Depending on the execution environment, the timeouts may
be exceeded and could be a reason for random failures of these tests.

The change replaces all custom timeout values with the common timeout
already defined in AbstractDebugTest.

Contributes to
eclipse-platform#863
@fedejeanne
Copy link
Contributor Author

The test seems stable since #1036 was merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed test junit test related things Windows Happens on Windows OS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HeikoKlare @fedejeanne