[Sticky Scrolling] Fix separator color on windows

[Christopher-Hermann]

The separator in the sticky lines controls are drawn in a bad color on windows dark theme. With this change, the separator color is aligned with the theme.

Current coloring on windows:

How it should look like:

This is a follow up for #1894

[Christopher-Hermann]

@Wittmaxi could you please check if this solves the issue on windows dark theme? If not, I need to set the correct background color for the separator.

[BeckerWdf]

This is a follow up for #1894

You meant point "1" in #1894 (comment) ?

[Christopher-Hermann]

You meant point "1" in #1894 (comment) ?

Yes, correct. Linking the comment is actually a good idea :)

[github-actions]

Test Results

 1 815 files  ±0   1 815 suites  ±0   1h 35m 51s ⏱️ + 1m 36s
 7 668 tests ±0   7 439 ✅  - 1  228 💤 ±0  1 ❌ +1 
24 165 runs  ±0  23 415 ✅  - 1  749 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit fc4da2d. ± Comparison against base commit 4888a8c.

♻️ This comment has been updated with latest results.

[Wittmaxi]

This is what I see, so no, I Would not consider this a fix. I tried to play around with different color values but I could not find a good fix.
I primarily use dark mode, so I would really appreciate you fixing this :) - thanks for putting in the work!

[Christopher-Hermann]

I tried to play around with different color values but I could not find a good fix.

Could you try to set the color for both separator in StickyLinesControl line 180:
bottomSeparator.setBackground(Display.getDefault().getSystemColor(SWT.COLOR_WIDGET_LIGHT_SHADOW));

[Wittmaxi]

@Christopher-Hermann this is precisely what I tried (well, with another color) - it had no effect on the bars for me.

[Christopher-Hermann]

@Christopher-Hermann this is precisely what I tried (well, with another color) - it had no effect on the bars for me.

Okay, damn you SWT :D Then I need to check on my virtual machine if I can reproduce the error to find a solution.
But it's really strange, I assume that other separators are colored correctly on Windows dark theme.

[Wittmaxi]

@Christopher-Hermann Yes, I have had regular issues with SWT in the past - the dark theme seems to be especially prone to bugs and inconsistencies ;_;

[Christopher-Hermann]

Changed the implementation since I did not manage to color the separator on windows. Now a composite with background color is used:

I tested on Windows and MacOS, both are working. But I would be grateful for further testers

[BeckerWdf]

Tested on macOS: Looks good.

[BeckerWdf]

"summary": "Eclipse Platform 4.33 M1 Promotion",

I thought that M1 is a milestone without freeze period. Am I wrong?

[vogella]

I think all our milestones are without freezes these days. @akurtakov can you update us on the latest state of freezing stuff?

[Christopher-Hermann]

Tested on macOS: Looks good.

I found one more issue, the CSS Color Engine is overwriting the background color of the separator composite. I need to check how I can disable the CSS Engine for this composite.

[akurtakov]

I think all our milestones are without freezes these days. @akurtakov can you update us on the latest state of freezing stuff?

Milestones don't have freezes but there is still the "promotion" day in the calendar (so everyone can see when it is) and the script checking it https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/42b625b2b0e971e1147761a7473e55170a3f5504/.github/workflows/verifyFreezePeriod.yml#L22 doesn't distinguish between M, RC and R promotion thus we end up with this freezes during M promotion days. It would be nice if someone enhances the script to not complain for milestone promotions.

[vogella]

I think all our milestones are without freezes these days. @akurtakov can you update us on the latest state of freezing stuff?

Milestones don't have freezes but there is still the "promotion" day in the calendar (so everyone can see when it is) and the script checking it https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/42b625b2b0e971e1147761a7473e55170a3f5504/.github/workflows/verifyFreezePeriod.yml#L22 doesn't distinguish between M, RC and R promotion thus we end up with this freezes during M promotion days. It would be nice if someone enhances the script to not complain for milestone promotions.

Create eclipse-platform/eclipse.platform.releng.aggregator#2170 for this.

[vogella]

Tested on macOS: Looks good.

I found one more issue, the CSS Color Engine is overwriting the background color of the separator composite. I need to check how I can disable the CSS Engine for this composite.

We have a css tag for this. See https://www.vogella.com/tutorials/Eclipse4CSS/article.html#ignore-certain-widgets-during-styling

[Christopher-Hermann]

We have a css tag for this. See https://www.vogella.com/tutorials/Eclipse4CSS/article.html#ignore-certain-widgets-during-styling

Thanks a lot, this did the trick.

[vogella]

I think all our milestones are without freezes these days. @akurtakov can you update us on the latest state of freezing stuff?

Milestones don't have freezes but there is still the "promotion" day in the calendar (so everyone can see when it is) and the script checking it https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/42b625b2b0e971e1147761a7473e55170a3f5504/.github/workflows/verifyFreezePeriod.yml#L22 doesn't distinguish between M, RC and R promotion thus we end up with this freezes during M promotion days. It would be nice if someone enhances the script to not complain for milestone promotions.

This should be fixed now by @sratz

[Christopher-Hermann]

The PR is ready for review/merging from my side.

[BeckerWdf]

@Christopher-Hermann
Can you pls. rebase and resolve conflicts?

[Christopher-Hermann]

@Christopher-Hermann Can you pls. rebase and resolve conflicts?

Done.

[BeckerWdf]

failed this as already known in #926