Parameterize browser tests to execute them for Edge browser #671 #672
+106
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 485 files - 1 485 suites - 1 9m 46s ⏱️ + 2m 39s For more details on these failures, see this check. Results for commit b26001f. ± Comparison against base commit c305b75. This pull request removes 230 and adds 390 tests. Note that renamed tests count towards both.This pull request removes 5 skipped tests and adds 9 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
HeikoKlare
force-pushed
the
issue-671
branch
8 times, most recently
from
abe200b
to
f4ac8dc
Compare
HeikoKlare
added a commit
to HeikoKlare/eclipse.platform.swt
that referenced
this pull request
May 22, 2023
…latform#671 Browser tests were only executed for the default configuration of a system's browser using the SWT.NONE flag. Other configurations, such as using the Edge browser in Windows, were not tested. This change parameterizes the browser tests to also execute them for the Edge browser on Windows. It also deactivates those tests for the Edge browser for which the implementation does (currently) not work. This allows to detect regressions when performing future changes to the Edge browser. Fixes eclipse-platform#672
HeikoKlare
force-pushed
the
issue-671
branch
3 times, most recently
from
31c2a39
to
549a829
Compare
HeikoKlare
commented
May 23, 2023
Comment on lines
+232
to
+253
| if (isEdge) { | ||
| // wait for and process pending events to properly cleanup Edge browser resources | ||
| do { | ||
| processUiEvents(); | ||
| try { | ||
| Thread.sleep(100); | ||
| } catch (InterruptedException e) { | ||
| } | ||
| } while (Display.getCurrent().readAndDispatch()); | ||
| } |
There was a problem hiding this comment.
This is necessary because otherwise some OS events that are somehow produced by one test occur and are processed by the next test and may interfere with the Edge browser instantation. I have invested quite some time to identify where the events come from and how to properly handle them, but I did not find a proper way to do so. If someone is able to identify the reasons for the events and how to properly process them, I would be glad to have a better solution than this,
|
@HeikoKlare can this be merged? |
|
|
I converted this back to draft due to the recent test failure and I will have another look at it. |
HeikoKlare
force-pushed
the
issue-671
branch
4 times, most recently
from
9dd213d
to
b002ced
Compare
HeikoKlare
force-pushed
the
issue-671
branch
2 times, most recently
from
4d2a5a1
to
fde88d9
Compare
…latform#671 Browser tests were only executed for the default configuration of a system's browser using the SWT.NONE flag. Other configurations, such as using the Edge browser in Windows, were not tested. This change parameterizes the browser tests to also execute them for the Edge browser on Windows. It also deactivates those tests for the Edge browser for which the implementation does (currently) not work. This allows to detect regressions when performing future changes to the Edge browser. Fixes eclipse-platform#671
HeikoKlare
force-pushed
the
issue-671
branch
2 times, most recently
from
ffb43cd
to
b26001f
Compare
HeikoKlare
force-pushed
the
issue-671
branch
from
b26001f
to
d6640f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browser tests were only executed for the default configuration of a system's browser using the
SWT.NONEflag. Other configurations, such as using the Edge browser in Windows, were not tested.This change parameterizes the browser tests to also execute them for the Edge browser on Windows. It also deactivates those tests for the Edge browser for which the implementation does (currently) not work. This allows to detect regressions when performing future changes to the Edge browser.
Fixes #671