[GTK4] Migrate FileDialog to new GTK FileDialog API #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Open Dialog (GTK3) Open Dialog (GTK4) Save Dialog (GTK3) Save Dialog (GTK4) |
|
The Mac crash is probably unrelated? And for GTK3, I seem to require a GTK3_LOAD_FUNCTION macro. I'm not exactly sure how it plays into SWT, but couldn't I simply copy the macro? |
ptziegler
force-pushed
the
gtk4-file-dialog
branch
from
a345f40
to
2860ed2
Compare
The FileChooser API has been marked as deprecated with GTK 4.10 and replaced by the FileDialog API. With this contribution, this old API has now been limited to GTK3. Following methods have been added to OS.java: - g_list_store_new - g_list_store_append Following methods have been moved from GTK.java to GTK3.java: - gtk_file_chooser_add_filter - gtk_file_chooser_get_filter - gtk_file_chooser_set_current_name - gtk_file_chooser_set_filter - gtk_file_chooser_set_select_multiple - gtk_file_chooser_native_new Following constant has been added to GTK.java: - GTK_TYPE_FILE_FILTER Following methods have been removed from GTK4.java: - gtk_file_chooser_get_files - gtk_file_chooser_get_file - gtk_file_chooser_set_current_folder - gtk_file_chooser_set_file Following methods have been added to GTK4.java: - gtk_file_dialog_set_initial_name - gtk_file_dialog_set_initial_file - gtk_file_dialog_set_title - gtk_file_dialog_set_default_filter - gtk_file_dialog_set_filters - gtk_file_dialog_get_default_filter - gtk_file_dialog_open_multiple - gtk_file_dialog_open_multiple_finish - gtk_file_dialog_open - gtk_file_dialog_open_finish - gtk_file_dialog_save - gtk_file_dialog_save_finish This commit also amends an oversight from 2e61b4b where the title of the directory dialog was no longer set. Contributes to: eclipse-platform#652
akurtakov
force-pushed
the
gtk4-file-dialog
branch
from
2860ed2
to
31a81f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FileChooser API has been marked as deprecated with GTK 4.10 and replaced by the FileDialog API. With this contribution, this old API has now been limited to GTK3.
Following methods have been added to OS.java:
Following methods have been moved from GTK.java to GTK3.java:
Following constant has been added to GTK.java:
Following methods have been removed from GTK4.java:
Following methods have been added to GTK4.java:
This commit also amends an oversight from
2e61b4b where the title of the directory dialog was no longer set.
Contributes to:
#652