Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Temporarily use tycho-apitools:verify mojo in version 4.0.8 #2380

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

HannesWell
Copy link
Member

Temporarily revert the tycho-apitools:verify mojo to version 4.0.8 for API checks to hopefully unblock verification builds that are currently suffering from #2360 (comment).

Temporarily revert the tycho-apitools:verify mojo to version 4.0.8 for
API checks to unblock verification builds.
@HannesWell
Copy link
Member Author

After about 150 projects checked this failed with

[ERROR] Failed to execute goal org.eclipse.tycho:tycho-apitools-plugin:4.0.8:verify (verify) on project org.eclipse.ui.genericeditor:
Execute ApiApplication failed: InvocationTargetException:
Error reading manifest for
/home/jenkins/agent/workspace/atform.releng.aggregator_PR-2380/.m2/repository/p2/osgi/bundle/jakarta.inject.jakarta.inject-api.source/2.0.1/jakarta.inject.jakarta.inject-api.source-2.0.1.jar:
zip file is empty -> [Help 1]

But I'm in doubt that this is really related to this change.
And since it cannot really get worse I'll submit this to see how it works in the different repositories.

@HannesWell HannesWell merged commit cadcd4d into eclipse-platform:master Sep 23, 2024
3 of 4 checks passed
@HannesWell HannesWell deleted the api-check-with-4.0.8 branch September 23, 2024 17:47
@HannesWell
Copy link
Member Author

Btw. only for the native SWT fragments still Tycho 4.0.9 is used because it's version is explicitly configured there:

If we we need this to have an effect there too we have to inherit the version from the parent. But currently SWT sufferes bigger problems:
#2360 (comment)

@HannesWell
Copy link
Member Author

At least for eclipse.platform and eclipse.platform.ui it looks like the apitools verification now works again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant