provide junit ScreenshotOnFailure TestWatcher

[jukzi]

No description provided.

[HeikoKlare]

May this be better placed in org.eclipse.core.tests.harness, since it is not related to performance tests?

[akurtakov]

May this be better placed in org.eclipse.core.tests.harness, since it is not related to performance tests?

Probably even better place is https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/tree/master/eclipse.platform.releng/bundles/org.eclipse.test .

[akurtakov]

Please move to org.eclipse.test bundle.

[jukzi]

Moving it would be a hell of work. Moving the class would be an API breakage. TracingSuite requires it needs to be fixed, Access restrictions need to be fixed... . I don't like how it is either, but to clean up that mess seems too complicated :-(

[akurtakov]

Tests are not API incl org.eclipse.test. Does it make the task easier?

[jukzi]

technically they are API. Some tests just do not include org.eclipse.test but the performance one. so no it's not helpful.

[akurtakov]

Everything should be in o.e.test without any breakage so you can patch Screenshots in o.e.test bundle.

[akurtakov]

Tests in I-build seems to be in good shape now.