Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get out of ubuntu 22 image building #2357

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

akurtakov
Copy link
Member

EF provided 24.04 is used in smoke tests.

@akurtakov akurtakov self-assigned this Sep 18, 2024
@HannesWell
Copy link
Member

As discussed privately it would be good to await #2271 (which is hopefully submitted tomorrow) so that we have the required change in the Jenkins job to build the images in this PR too.

In the meantime, I think the image definition itself should be removed too, shouldn't it?
I.e. I think the entire directory should be deleted at
https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/tree/master/cje-production/dockerfiles/ubuntu-gtk3-metacity

@akurtakov
Copy link
Member Author

As discussed privately it would be good to await #2271 (which is hopefully submitted tomorrow) so that we have the required change in the Jenkins job to build the images in this PR too.

In the meantime, I think the image definition itself should be removed too, shouldn't it? I.e. I think the entire directory should be deleted at https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/tree/master/cje-production/dockerfiles/ubuntu-gtk3-metacity

Yes. That one should be deleted too.

EF provided 24.04 is used in smoke tests.
@HannesWell
Copy link
Member

Updated this PR to the top of the master and removed the suggested files too.

Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should now be complete but is not tested by the verification build, so there is no need to wait for a successful build.

@HannesWell HannesWell merged commit 54adbc2 into eclipse-platform:master Sep 20, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants