Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish platform features to Maven central #1422

Closed
wants to merge 1 commit into from
Closed

Conversation

vogella
Copy link
Contributor

@vogella vogella commented Oct 6, 2023

Feature can be used in a target platform to retrieve the plug-ins listed in them, see eclipse-m2e/m2e-core#636

Publishing these features would allow a user to use these features to define their set of available platform plug-ins based on pure Maven targets.

Fixes #1421

@merks
Copy link
Contributor

merks commented Oct 6, 2023

Note that no verification build will actually test that this works. Also note that should you choose to change this to suit your personal wishes and goals, then you will be assuming responsibility for maintaining and supporting it in the future, including and especially when this fails to publish to maven central after the release.

@vogella
Copy link
Contributor Author

vogella commented Oct 6, 2023

to suit your personal wishes and goals

I would not say that I have personal wishes to see features published at Maven central. But RCP clients are moving into the direction of using Maven based target platforms and listing all plug-ins into a target is time consuming and error-prone especially as the the required set of plug-ins is changing.

The support of Feature dependencies in the target files was added by @laeubi and @ptziegler.

Of course it is fine to revert this change if publishing to Maven fails with feature jar files.

@merks
Copy link
Contributor

merks commented Oct 6, 2023

It would seem better to support BOMs, i.e., something Maven actually understands. But that's my personal my opinion.

Please note, if it's not clear already, that actual publishing to Maven happens after the release and so any failure to follow all the nexus publishing rules will happen at the most inopportune moment possible.

Please ensure that you are able to and prepared to take full responsibility for changes to the current process, especially as it will have an impact in December.

@vogella
Copy link
Contributor Author

vogella commented Nov 21, 2023

@merks do we have a good estimation when the Maven publish is planned to happen so that I can plan to reserve time to look into potential issues? I have a big client who is very interested in using the features from Maven central.

Feature can be used in a target platform to retrieve the plug-ins listed
in them, see eclipse-m2e/m2e-core#636

Publishing these features would allow a user to use these features to
define their set of available platform plug-ins based on pure Maven
targets.

Fixes #1421
@merks
Copy link
Contributor

merks commented Nov 21, 2023

@merks do we have a good estimation when the Maven publish is planned to happen so that I can plan to reserve time to look into potential issues? I have a big client who is very interested in using the features from Maven central.

Please read this carefully:

#1421 (comment)

Your big client, or you, will need to make a significant investment in satisfying these interests.

@akurtakov
Copy link
Member

Do you plan working on this one? If not maybe we should close it.

@akurtakov
Copy link
Member

Lars, now is the right time to work on this one for June release unless you gave up on this one.

@vogella
Copy link
Contributor Author

vogella commented Mar 13, 2024

I gave up on this one

@vogella vogella closed this Mar 13, 2024
@vogella vogella deleted the publish-features branch March 13, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish Eclipse features also to Maven central
3 participants