Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference to 4.31 in p2.inf files #1974

Open
jonahgraham opened this issue Apr 11, 2024 · 8 comments
Open

Reference to 4.31 in p2.inf files #1974

jonahgraham opened this issue Apr 11, 2024 · 8 comments

Comments

@jonahgraham
Copy link
Contributor

Hi releng folk,

as an update to #1854 it looks like there are still some references to 4.31, for example:

@jonahgraham
Copy link
Contributor Author

Here is the line in the other p2.inf file:

@jonahgraham
Copy link
Contributor Author

I guess this script needs an update to capture it for the next version:

find $script_location/.. -name pom.xml -exec sed -i 's/4.31.0/4.32.0/g' {} \;

@MohananRahul
Copy link
Contributor

I guess this script needs an update to capture it for the next version:

find $script_location/.. -name pom.xml -exec sed -i 's/4.31.0/4.32.0/g' {} \;

I think this is usually done when the release happens.

@jonahgraham
Copy link
Contributor Author

I guess this script needs an update to capture it for the next version:

find $script_location/.. -name pom.xml -exec sed -i 's/4.31.0/4.32.0/g' {} \;

I think this is usually done when the release happens.

My comment was unclear - that comment meant I think a line needs to be added to it, e.g. something like the following so that next version the p2.inf change isn't missed.

find $script_location/.. -type f -name *.p2.inf -exec sed -i 's/4.31/4.32/g' {} \;

In addition, I think there are some other places that say 4.31 that probably shouldn't still, but I haven't done a full check:

<description>Redirect 4.30 p2 repos to 4.31 and redirect 4.31 repos 4.32 to begin development on the open master streams immediately.</description>

-header "<span style='font-size:small'><b>Eclipse Platform</b><br>2024-03 (4.31)</span>"

There are a bunch of other search result for 4.31, some of them look out of date too.

@merks
Copy link
Contributor

merks commented Apr 12, 2024

FYI. The setup tasks indicated above are disabled and will be modified and enabled when 4.33 master opens but 4.32 is not yet released.

@akurtakov
Copy link
Member

Is there anything to be done here?

@jonahgraham
Copy link
Contributor Author

The files were manually updated in #1975, but the script wasn't updated yet so it seems this problem will recur in the next version bump. If the script should not be updated, this issue can be closed.

@akurtakov
Copy link
Member

What is the status here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants