Plug-In Image browser does not highlight the current page in dark theme #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 279 files 279 suites 53m 49s ⏱️ Results for commit 9dbbe52. ♻️ This comment has been updated with latest results. |
lathapatil
force-pushed
the
Issues/822_PageNavigation_DarkThemeIssue
branch
from
f1ab46e
to
3337ee3
Compare
|
@vogella could you review the code and check if this fix is required here ? |
lathapatil
force-pushed
the
Issues/822_PageNavigation_DarkThemeIssue
branch
from
3337ee3
to
65e8b4f
Compare
Temporary fix to disable the styling for current page (Hyperlink widget) and setting white color to it (only if current theme is Dark Theme ). Fixes eclipse-pde#822
laeubi
force-pushed
the
Issues/822_PageNavigation_DarkThemeIssue
branch
from
65e8b4f
to
9dbbe52
Compare
|
@vogella can you please review? |
Before fix : Dark theme
After Fix : Dark theme
Light Theme (No change after fix)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary fix to disable the styling for current page (Hyperlink widget) and setting white color to it (only if current theme is Dark Theme ).
Fixes #822