[PDE-Build] Use 1.8 as default javac target/source-level in scripts #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ECJ does not support Java versions below 1.8 anymore. Contributes to fixing eclipse-platform/eclipse.platform.releng.aggregator#2197
Test Results 291 files + 3 291 suites +3 54m 16s ⏱️ + 5m 39s For more details on these errors, see this check. Results for commit 15e8917. ± Comparison against base commit d9226ab. |
|
Looks like all errors caused by ECJ dropping java targets below 1.8 are now fixed. |
HannesWell
commented
Jul 25, 2024
| @@ -1068,9 +1068,9 @@ private void generateCompilerSettings() throws CoreException { | |||
| script.printProperty(PROPERTY_PREREQ_COMPILE_LOG, Utils.getPropertyFormat(PROPERTY_BUILD_DIRECTORY) + "/prereqErrors.log"); //$NON-NLS-1$ | |||
|
|
|||
| if (javacSource == null) | |||
| script.printProperty(IXMLConstants.PROPERTY_JAVAC_SOURCE, "1.3"); //$NON-NLS-1$ | |||
| script.printProperty(IXMLConstants.PROPERTY_JAVAC_SOURCE, "1.8"); //$NON-NLS-1$ | |||
There was a problem hiding this comment.
To make this more robust the new API for the earliest Java target supported by ECJ could be used.
HannesWell
added a commit
to HannesWell/eclipse.pde
that referenced
this pull request
Jul 28, 2024
HannesWell
added a commit
to HannesWell/eclipse.pde
that referenced
this pull request
Aug 6, 2024
HannesWell
added a commit
to HannesWell/eclipse.pde
that referenced
this pull request
Aug 6, 2024
HannesWell
added a commit
that referenced
this pull request
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECJ does not support Java versions below 1.8 anymore.
Contributes to fixing
eclipse-platform/eclipse.platform.releng.aggregator#2197
Reference to eclipse-jdt/eclipse.jdt.core#2551.