-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E4 Editor is not able to discover references from dynamic model contributions #1307
Comments
Hi Christoph, could you join your sample project to check it ? |
@opcoach You can easily create just some random bundles as described above, let me know if any step is unclear. If you create a new fragment the wizard will be asked if you want the dynamic way or the static way (using plugin.xml) thats it: |
About the 'find' button in model editor dialog, nothing is really found anyway and not only in the import section of the editor... This issue should consider to review all the find mechanisms in the editor... For instance, if you create another model fragment with some MPlaceHolder, you should be able to bind it to an existing E3 view (accessible with a dependency to the E3 plugin) ro to any partDescriptorsIDs (whatever their source definition (dynamic or static..)... Or if your plugin depends on org.eclipse.ui and you create a model fragment with an import of a command... you should see all the command IDs provided by org.eclipse.ui... that would be the case where your model fragment will provide an additional handler for a low level command (like org.eclipse.ui.edit.copy)... Actually there is not index in E4 that contains all the objects accessible depending on their types.. or if there is one, it is not updated when new fragments or dependencies are added or changed... So may be this issue should be closed and reopened in a more general issue : 'Fix the find mechanism in the model editors". There is also a label mistake in the dialog : should be named 'New Application fragment model'... |
As said when I define it in |
I really like using the dynamic model registration but found one problem today, the E4 editor seem not be able to discover such contributions (FYI @fipro78)
plugin.xml
MANIFEST.MF
plugin.xml
defining one is found, the one fromMANIFEST.MF
is notThe text was updated successfully, but these errors were encountered: