Skip to content

Commit

Permalink
Adjust lower bound for dependency to JDT Launching in PDE Build
Browse files Browse the repository at this point in the history
The PDEState class is using JavaRuntime.getProvidedVMPackages(...),
which has only been added with version 3.22. But the Manifest still only
requires 3.21. This causes issues when installing the latest PDE in the
Eclipse 4.31, as the JDT bundles are not updated, which therefore leads
to a NoSuchMethodError.

See eclipse-windowbuilder/windowbuilder#865
for a real-life example of this problem.

Amends 00c9caf
  • Loading branch information
ptziegler authored and merks committed Aug 9, 2024
1 parent f3c556e commit edf6f1b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion build/org.eclipse.pde.build/META-INF/MANIFEST.MF
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.29.0,4.0.0)",
org.eclipse.equinox.p2.repository.tools;bundle-version="[2.4.200,3.0.0)";resolution:=optional,
org.eclipse.equinox.p2.publisher.eclipse;bundle-version="1.5.200",
org.eclipse.jdt.core;bundle-version="[3.36.0,4.0.0)",
org.eclipse.jdt.launching;bundle-version="[3.21.0,4.0.0)"
org.eclipse.jdt.launching;bundle-version="[3.22.0,4.0.0)"
Import-Package: org.eclipse.equinox.frameworkadmin;version="[2.0.0,3.0.0)",
org.eclipse.equinox.internal.p2.core.helpers,
org.eclipse.equinox.internal.p2.engine,
Expand Down

0 comments on commit edf6f1b

Please sign in to comment.