Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github.com/gorilla/websocket Depreciated - Should we move to an alternative (and, if so, what) #627

Closed
zhoub opened this issue Jan 11, 2023 · 4 comments

Comments

@zhoub
Copy link

zhoub commented Jan 11, 2023

Hi,

Since https://github.com/gorilla/websocket was archived, I think it's best to switch to https://pkg.go.dev/golang.org/x/net/websocket .

Thanks in advance.

@MattBrittan
Copy link
Contributor

Based upon this issue I believe that golang.org/x/net/websocket is effectively depreciated as well. There is an open PR #583 (issue #585) that moves to nhooyr/websocket but I was reluctant to accept this because it led to a 12% increase (around 800kb) in the size of a test app with no real benefit (webassembly should be able to be supported using ClientOptions.SetCustomOpenConnectionFn).

I'm interested in feedback on this - will change the title of your post to make it clear that this is a broader discussion and see if anyone else has thoughts..

@MattBrittan MattBrittan changed the title Use https://pkg.go.dev/golang.org/x/net/websocket Instead of github.com/gorilla/websocket golang.org/x/net/websocket Depreciated - Should we move to an alternative (and, if so, what) Jan 11, 2023
@MattBrittan MattBrittan changed the title golang.org/x/net/websocket Depreciated - Should we move to an alternative (and, if so, what) github.com/gorilla/websocket Depreciated - Should we move to an alternative (and, if so, what) Jan 11, 2023
@lxzan
Copy link

lxzan commented May 31, 2023

try https://github.com/lxzan/gws , provide better performance, easier to use API

@bmarinov
Copy link

bmarinov commented Aug 3, 2023

No longer deprecated :) see https://gorilla.github.io/blog/2023-07-17-project-status-update/
o/

@MattBrittan
Copy link
Contributor

Closing this as the Gorilla libraries are now being maintained again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants