Support java behaviour w.r.t fmin/fmax/dmin/dmax #20185
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add functional tests for `Math.max` and `Math.min`: - to test specific float and double corner cases - test with NaN, +0, & -0, values to confirm respective omr changes - test all possible execution paths Signed-off-by: Sarwat Shaheen <[email protected]>
- Adds java_lang_Math_max/min_float/double as a recognized method - Adds a SupportsInlineMath_MaxMin_FD flag to the Z code generator - Flag is only set in Z if the TR_disableInlineMath_MaxMin_FD environment variable is not set - If the flag is set, call nodes are transformed to a functionally equivalent tree that uses fmax/fmin/dmax/dmin Signed-off-by: Sarwat Shaheen <[email protected]>
matthewhall2
force-pushed
the
fmin_fmax_dmin_dmax
branch
16 times, most recently
from
b91d9a0
to
9249957
Compare
- separate evaluators for J9 vs omr to return the NaN unchanged - compare int/long bits instead of float bits to check behaviour for +-0 and NaNs Signed-off-by: Matthew Hall <[email protected]>
matthewhall2
force-pushed
the
fmin_fmax_dmin_dmax
branch
from
9249957
to
4201acc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables inlining of f/d min ax functions
Implements Java standard found while testing
Depends on OMR PR:Support IEEE-754 w.r.t fmin/fmax/dmin/dmax eclipse/omr#7464
https://hyc-runtimes-jenkins.swg-devops.com/job/jvm.29.personal/34226/