-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable openjdk test - jdk_bean #20531
Comments
Issue Number: 20531 |
@annaibm could you run the test on all platforms? Thanks |
|
The failure on jdk8 is already resolved via ibmruntimes/openj9-openjdk-jdk8#780 @babsingh pls take a look at the jdk11 failures. |
Thanks @pshipton With the latest JDK8, the
|
- Enable jck_beans on xlinux except for java version 8 and 11 related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
OpenJ9 JDK8 and JDK11 currently use OpenJ9 MethodHandles. Enabling jdk_bean in JDK8 and JDK11 triggers certain OpenJDK MethodHandles code paths. However, OpenJ9 MethodHandles are in use for JDK8 and JDK11, so OpenJDK MethodHandles paths shouldn't be activated. To address this, a MethodHandleImpl stub was added, used only with OpenJ9 MethodHandles, and not when OpenJDK MethodHandles are enabled. Related: eclipse-openj9#20531 Signed-off-by: Babneet Singh <[email protected]>
- Enable jck_beans on xlinux except for java version 8 and 11 related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
OpenJ9 JDK8 and JDK11 currently use OpenJ9 MethodHandles. Enabling jdk_bean in JDK8 and JDK11 triggers certain OpenJDK MethodHandles code paths. However, OpenJ9 MethodHandles are in use for JDK8 and JDK11, so OpenJDK MethodHandles paths shouldn't be activated. To address this, a MethodHandleImpl stub was added, used only with OpenJ9 MethodHandles, and not when OpenJDK MethodHandles are enabled. Related: eclipse-openj9#20531 Signed-off-by: Babneet Singh <[email protected]>
- Enable jdk_beans on xlinux except for java version 8 and 11 related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
- Enable jdk_beans on xlinux except for java version 8 and 11 related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
- Enable jdk_beans on xlinux except for java version 8 and 11 related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
- Enable jdk_beans on xlinux except for java version 8 and 11 related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
- Enable jdk_beans on xlinux for all java versions related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
- Enable jdk_beans on xlinux for all java versions related: eclipse-openj9/openj9#20531 Signed-off-by: Anna Babu Palathingal <[email protected]>
jdk_beans got excluded as part of the general exclude a while back via #10757.
https://github.com/adoptium/aqa-tests/blob/a498becc695f7bdeaa7c4b3752c827e65aa7e123/openjdk/playlist.xml#L755
My limited testing can pass on xlinux JDK17, 21 and 23. We still need to look into xlinux JDK8 and JDK11 failures. But I think we should look into re-enabling this test.
This would help us to discover issues like https://bugs.openjdk.org/browse/JDK-8336862 early.
Presumably, we will hit the same issue on Windows: adoptium/aqa-tests#5690 (comment)
The text was updated successfully, but these errors were encountered: