Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIDD transport layer identifiers #946

Closed
madhushreegc opened this issue Dec 10, 2020 · 10 comments
Closed

NIDD transport layer identifiers #946

madhushreegc opened this issue Dec 10, 2020 · 10 comments
Labels
question Any question about leshan

Comments

@madhushreegc
Copy link

Hi,

Leshan version : leshan-2.0.0-M1

I am using NIDD transport . We have SCEF in-between UE and LWM2M server .

We have our own connector and its endpointContext will have all necessary details required like externalId .

I need to pass externalId to isAuthorized method of CustomLeshanAuthorizerService class. Can Identity class be enhanced to add the entries from endpointContext along with other details during register, update or deregister?

Regards,
Madhushree.

@sbernard31
Copy link
Contributor

org.eclipse.leshan.server.security.Authorizer is in leshan-server-core and so is not aware about CoAP/Californium/Scandium (and so endpointContext from element connector)

So either :

  1. We make the EndpointContextUtil a dynamic object which could be replace in Leshan. (providing it in the builder for example) And so use can create more complex identity.
    2.Or we add a getCoapRequest() in LwM2mRequest like we have for a getCoapResponse() with LwM2mResponse and user is able to retrieve the endpointcontext from the coap request.

I think both could be a good idea but maybe 2. is a good start as it make Request and Response API consistent ?

@sbernard31 sbernard31 added the question Any question about leshan label Dec 10, 2020
@madhushreegc
Copy link
Author

Yes . We can go with option 2 .

Thank you for quick response .

@sbernard31
Copy link
Contributor

So this should be solved by : #198

@sbernard31
Copy link
Contributor

A work in progress available at : #947

@sbernard31
Copy link
Contributor

As #947 is integrated in master. I close this issue. (The feature should be available in v2.0.0-M2)

@madhushreegc, maybe you could consider to a comment on #830 ?

@madhushreegc
Copy link
Author

madhushreegc commented Dec 15, 2020

@sbernard31 , yes commented in #830 . Thanks 👍

@sbernard31
Copy link
Contributor

@madhushreegc, thanks you very much 🙏 !

Do you think it's OK if I add HPE as leshan adopters : https://www.eclipse.org/leshan/#who%20is%20using ?

@sbernard31
Copy link
Contributor

@madhushreegc, the 2.0.0-M2 is out with the last feature you need.
(Just to let you know I will be not available next 2 weeks)

@sbernard31
Copy link
Contributor

@madhushreegc I hope I didn't boring you too much with this, but I didn't succeed to get an answer from you about this.

Do you think it's OK if I add HPE as leshan adopters : https://www.eclipse.org/leshan/#who%20is%20using ?

@madhushreegc
Copy link
Author

@sbernard31 , Sorry I missed this . Let me check with my manager once and come back on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Any question about leshan
Projects
None yet
Development

No branches or pull requests

2 participants