Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous subscription at a specific frequency #21

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rafaeling
Copy link
Contributor

@rafaeling rafaeling commented Mar 6, 2024

See eclipse/kuksa.val#734 for more information

Dont forget to update submodules correctly to the one in here: https://github.com/boschglobal/kuksa.val/tree/add_continuous_subscription
it contains the new proto API definition

@rafaeling rafaeling force-pushed the add_continuous_subscription branch from d8fd8d5 to 30b161e Compare March 6, 2024 16:08
@erikbosch
Copy link
Contributor

Failure is expected as Databroker submodule isn't updated. For test purposes we could update submodule reference as soon as the change is merge in kuksa.val, but I would prefer if kuksa.val (and Databroker) is released so that we actually can integrate and test towards a release version. I.e. creating a 0.4.2 version of Databroker. As KUKSA Databroker migration is in progress we could decide if the new release should be the last release of the old location, or the first of the new location.

Creating a release/tagged version of Databroker also helps all other repos that maintain local copies of the Proto-files, so that they can refer to they a specific version of the proto files.

With this update it would also be good if we could update the tests, possibly adding one or more test cases to the file below to show that we handle the frequency argument correctly
https://github.com/eclipse-kuksa/kuksa-python-sdk/blob/main/kuksa-client/tests/test_grpc.py

@lukasmittag
Copy link
Contributor

do we want to give the cli the ability as well?

@boschglobal boschglobal closed this by deleting the head repository Mar 21, 2024
@erikbosch
Copy link
Contributor

Reopening all PRs closed by accident by boschglobal maintenance

@erikbosch erikbosch reopened this Mar 21, 2024
@erikbosch erikbosch marked this pull request as draft June 4, 2024 11:41
@erikbosch
Copy link
Contributor

Converted to draft as it is still is work in progress, correct @rafaeling ?

@rafaeling
Copy link
Contributor Author

rafaeling commented Jun 4, 2024

Converted to draft as it is still is work in progress, correct @rafaeling ?

Correct, thanks

@erikbosch
Copy link
Contributor

@rafaeling - worth keeping?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants