-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continuous subscription at a specific frequency #21
base: main
Are you sure you want to change the base?
Continuous subscription at a specific frequency #21
Conversation
efe4221
to
d6c4c0c
Compare
d8fd8d5
to
30b161e
Compare
Failure is expected as Databroker submodule isn't updated. For test purposes we could update submodule reference as soon as the change is merge in kuksa.val, but I would prefer if kuksa.val (and Databroker) is released so that we actually can integrate and test towards a release version. I.e. creating a 0.4.2 version of Databroker. As KUKSA Databroker migration is in progress we could decide if the new release should be the last release of the old location, or the first of the new location. Creating a release/tagged version of Databroker also helps all other repos that maintain local copies of the Proto-files, so that they can refer to they a specific version of the proto files. With this update it would also be good if we could update the tests, possibly adding one or more test cases to the file below to show that we handle the frequency argument correctly |
do we want to give the cli the ability as well? |
Reopening all PRs closed by accident by boschglobal maintenance |
Converted to draft as it is still is work in progress, correct @rafaeling ? |
Correct, thanks |
@rafaeling - worth keeping? |
See eclipse/kuksa.val#734 for more information
Dont forget to update submodules correctly to the one in here: https://github.com/boschglobal/kuksa.val/tree/add_continuous_subscription
it contains the new proto API definition