Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KubernetesWatchTaskTest: Statement lambda can be replaced with expression lambda #3372

Open
manusa opened this issue Sep 6, 2024 · 5 comments
Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers

Comments

@manusa
Copy link
Member

manusa commented Sep 6, 2024

Description

The class KubernetesWatchTaskTest presents the issue: Statement lambda can be replaced with expression lambda.

The following line:

dockerBuildServiceMockedConstruction = mockConstruction(DockerBuildService.class, (mock, ctx) -> {
when(mock.isApplicable()).thenReturn(true);
});

should be changed to:

    dockerBuildServiceMockedConstruction = mockConstruction(DockerBuildService.class, (mock, ctx) -> when(mock.isApplicable()).thenReturn(true));

🔴 Before you start 🔴

👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇

Make sure you read the contributing guide first.

Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

This is a first-timers-only issue. These issues are especially created for contributors who are contributing to the project for the first time.

If you have already contributed to this project in the past, please don't ask to be assigned one of these issues and look for good-first-issues or help-wanted issues instead in order to continue you contributor journey in the project.

@manusa manusa added first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers labels Sep 6, 2024
@bgayatri3
Copy link

Hi, could I get this issue

@pujakarakoti07
Copy link
Contributor

I want to contribute to this issue

@manusa
Copy link
Member Author

manusa commented Sep 16, 2024

Hi @pujakarakoti07 I just assigned #3368 to you

@manusa
Copy link
Member Author

manusa commented Sep 25, 2024

Hi, could I get this issue

Hi @bgayatri3

It's been 3 weeks since the issue was assigned, are you still working on it or I can assign to someone else?

@bgayatri3
Copy link

Hi @manusa!

Apologies! I am still working on it, it will be done within the next week if that's ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants