-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AbstractNativeClientBuilder: Anonymous new DnsResolver() can be replaced with lambda #3369
Comments
I want to fix this issue can you please assign me? |
Hi @pujakarakoti07, you already have #3368 assigned to you. |
@rohanKanojia can i have this assigned? I wanna go through the contributions process as I am facing some issue while pushing it |
@bhavana61 : Have you forked the project? Please go through my blogpost How to contribute to Eclipse JKube for step by step guide in contributing process. |
Yes..I have gone through the process and I have commited the change |
@bhavana61 : Unfortunately ECA check is failing, I'm not sure if it happened by accident but you've created the commit with your work email account (not sure if it's the same email with which you signed ECA) |
i am not sure why this happened...I have changed the git config user.name and email before commiting...how can I change this? |
@rohanKanojia I have closed the old PRs with different account commits. Reopened the new one. can you check once? |
@bhavana61 : How did you make these changes? If you open the project in IntelliJ and load file there IntelliJ would give you a suggestion to replace the anonymous class with lambda. |
Description
The class AbstractNativeClientBuilder presents the issue: Anonymous new DnsResolver() can be replaced with lambda.
The following line:
jkube/jkube-kit/build/service/docker/src/main/java/org/eclipse/jkube/kit/build/service/docker/access/hc/util/AbstractNativeClientBuilder.java
Lines 81 to 86 in 5da6068
should be changed to:
🔴 Before you start 🔴
👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇
Make sure you read the contributing guide first.
Pay special attention to the ECA agreement section and the requirement to sign-off your commit.
This is a first-timers-only issue. These issues are especially created for contributors who are contributing to the project for the first time.
If you have already contributed to this project in the past, please don't ask to be assigned one of these issues and look for good-first-issues or help-wanted issues instead in order to continue you contributor journey in the project.
The text was updated successfully, but these errors were encountered: