Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractNativeClientBuilder: Anonymous new DnsResolver() can be replaced with lambda #3369

Closed
manusa opened this issue Sep 6, 2024 · 9 comments · Fixed by #3452
Closed
Assignees
Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers Hacktoberfest Issues accountable for the Hacktoberfest
Milestone

Comments

@manusa
Copy link
Member

manusa commented Sep 6, 2024

Description

The class AbstractNativeClientBuilder presents the issue: Anonymous new DnsResolver() can be replaced with lambda.

The following line:

return new DnsResolver() {
@Override
public InetAddress[] resolve(final String host) throws UnknownHostException {
return new InetAddress[] {null};
}
};

should be changed to:

        return host -> new InetAddress[] {null};

🔴 Before you start 🔴

👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇

Make sure you read the contributing guide first.

Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

This is a first-timers-only issue. These issues are especially created for contributors who are contributing to the project for the first time.

If you have already contributed to this project in the past, please don't ask to be assigned one of these issues and look for good-first-issues or help-wanted issues instead in order to continue you contributor journey in the project.

@manusa manusa added first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers labels Sep 6, 2024
@pujakarakoti07
Copy link
Contributor

I want to fix this issue can you please assign me?

@manusa
Copy link
Member Author

manusa commented Sep 17, 2024

Hi @pujakarakoti07, you already have #3368 assigned to you.

@manusa manusa added the Hacktoberfest Issues accountable for the Hacktoberfest label Sep 25, 2024
@bhavana61
Copy link
Contributor

@rohanKanojia can i have this assigned? I wanna go through the contributions process as I am facing some issue while pushing it

@rohanKanojia
Copy link
Member

@bhavana61 : Have you forked the project? Please go through my blogpost How to contribute to Eclipse JKube for step by step guide in contributing process.

@bhavana61
Copy link
Contributor

Yes..I have gone through the process and I have commited the change

@rohanKanojia
Copy link
Member

@bhavana61 : Unfortunately ECA check is failing, I'm not sure if it happened by accident but you've created the commit with your work email account (not sure if it's the same email with which you signed ECA)

@bhavana61
Copy link
Contributor

i am not sure why this happened...I have changed the git config user.name and email before commiting...how can I change this?

@bhavana61
Copy link
Contributor

@rohanKanojia I have closed the old PRs with different account commits. Reopened the new one. can you check once?

@rohanKanojia
Copy link
Member

@bhavana61 : How did you make these changes? If you open the project in IntelliJ and load file there IntelliJ would give you a suggestion to replace the anonymous class with lambda.

@manusa manusa added this to the 1.18.0 milestone Oct 11, 2024 — with automated-tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers Hacktoberfest Issues accountable for the Hacktoberfest
Projects
None yet
4 participants