Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testBug434044_comment36 fails with Java 1.7 JLS since I20240606-1800 #2537

Closed
iloveeclipse opened this issue Jun 7, 2024 · 7 comments
Closed
Labels
bug Something isn't working regression Something was broken by a previous change test Work on unit tests, no change of productive code

Comments

@iloveeclipse
Copy link
Member

See https://download.eclipse.org/eclipse/downloads/drops4/I20240606-1800/testresults/html/org.eclipse.jdt.core.tests.compiler_ep433I-unit-cen64-gtk3-java17_linux.gtk.x86_64_17.html

Note: we probably should drop support for Java < Java 8 now, see #820.

I've also created #2536.

@iloveeclipse iloveeclipse added bug Something isn't working regression Something was broken by a previous change labels Jun 7, 2024
@stephan-herrmann
Copy link
Contributor

This difference:

 expected:<...or the type capture#[3]-of ? extends Eclips...> but was:<...or the type capture#[2]-of ? extends Eclips...> 

is well in the range of acceptable fluctuation across compliance settings.
Creating one capture more or less is not a bug.

@iloveeclipse do you still want me to make the test expectation version dependent, or will we stop testing at 1.7 "immediately"?

@iloveeclipse
Copy link
Member Author

If it is eas, fix, fix it, if not, leave it. I hope I can work on removal soon, but this weekend I'm offline.

@jukzi jukzi added the test Work on unit tests, no change of productive code label Jun 19, 2024
@jukzi
Copy link
Contributor

jukzi commented Jun 19, 2024

Still failing. What is the plan for this issue? Disable tests <=1.7 ?

@iloveeclipse
Copy link
Member Author

See #2536

@kamilkrzywanski
Copy link
Contributor

But do capt

This difference:

 expected:<...or the type capture#[3]-of ? extends Eclips...> but was:<...or the type capture#[2]-of ? extends Eclips...> 

is well in the range of acceptable fluctuation across compliance settings. Creating one capture more or less is not a bug.

@iloveeclipse do you still want me to make the test expectation version dependent, or will we stop testing at 1.7 "immediately"?

but it isn't correct behaviour? Its's capture of 2 -
doFoo(String) in Foo and
doFoo (Integer)in Nasty 

Do enough is just change it to 2 instead of 3?

kamilkrzywanski added a commit to kamilkrzywanski/eclipse.jdt.core that referenced this issue Jul 8, 2024
kamilkrzywanski added a commit to kamilkrzywanski/eclipse.jdt.core that referenced this issue Jul 8, 2024
kamilkrzywanski added a commit to kamilkrzywanski/eclipse.jdt.core that referenced this issue Jul 8, 2024
kamilkrzywanski added a commit to kamilkrzywanski/eclipse.jdt.core that referenced this issue Jul 8, 2024
@kamilkrzywanski kamilkrzywanski mentioned this issue Jul 8, 2024
3 tasks
@stephan-herrmann
Copy link
Contributor

but it isn't correct behaviour? Its's capture of 2 -

Those numbers are not guaranteed, they are a way to visualize different captures of the same wildcard as different. Other than that this number has no meaning.

The point in this specific issue is: compilation at 1.7 vs 1.8 create different numbers of captures so the same capture gets different names.

@iloveeclipse
Copy link
Member Author

iloveeclipse commented Aug 1, 2024

Fixed after Java 8 update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression Something was broken by a previous change test Work on unit tests, no change of productive code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants