Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3: implement artifact range requests #95

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zyga
Copy link

@zyga zyga commented Oct 2, 2023

The basic itent is to allow expressing an input stream for a fragment that corresponds to a single range request.

This patch is not ready to land, because it requires lock-step update in HawkBit proper. The long story short, is that the current abstraction of getFileInputStream is just insufficient to efficiently implement range requests for artifacts.

There are two goals for efficiency:

  • We should not request or discard data we do not need
  • We read all the data we requested and close the stream properly

The second problem is somewhat elusive, since S3 input stream has a close() method that informs us of incorrect usage if not all content is drained, when S3 is sending the content but are are not reading.

Corresponging HawkBit change is posted to HawkBit in a separate patch.

Fixes: #91

The basic itent is to allow expressing an input stream for a fragment that
corresponds to a single range request.

This patch is not ready to land, because it requires lock-step update in
HawkBit proper. The long story short, is that the current abstraction of
getFileInputStream is just insufficient to efficiently implement range requests
for artifacts.

There are two goals for efficiency:

- We should not request or discard data we do not need
- We read all the data we requested and close the stream properly

The second problem is somewhat elusive, since S3 input stream has a close()
method that informs us of incorrect usage if not all content is drained, when
S3 is sending the content but are are not reading.

Corresponging HawkBit change is posted to HawkBit in a separate patch.

Fixes: eclipse-hawkbit#91
Signed-off-by: Zygmunt Krynicki <[email protected]>
@hawkbit-bot
Copy link

Can one of the admins verify this patch?

@zyga
Copy link
Author

zyga commented Oct 2, 2023

This depends on eclipse-hawkbit/hawkbit#1445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 extension does not work correctly with range requests to HawkBit artifacts
2 participants