Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Interface usage and default implementation sync across services #1400

Open
ndoschek opened this issue Sep 4, 2024 · 0 comments
Open
Labels
client enhancement New feature or request

Comments

@ndoschek
Copy link
Contributor

ndoschek commented Sep 4, 2024

Related to GH-1393
See also comment from Tobias: eclipse-glsp/glsp-client#388 (comment)

This issue aims to extend the pattern of injecting the interface instead of the default class to other services besides the manager classes (e.g., the selection service). Additionally, we need to ensure that interfaces and their corresponding default implementations remain synchronized across all services.

  • Review and align interfaces and default implementations for the remaining services.
  • Ensure that all public methods/fields in default implementations are reflected in the corresponding interfaces.
  • Update injections and bindings to match the pattern.
@ndoschek ndoschek added enhancement New feature or request client labels Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant