-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create end-to-end tests for all integrations and features #1154
Labels
Comments
tortmayr
added a commit
to eclipse-glsp/glsp-playwright
that referenced
this issue
Mar 2, 2024
- Add workflow for executing playwright tests for a dedicated GLSP component/project - Adapt playwright config to also report via `github-actions-repoter` when executed in a CI env - Adapt playwright config to consider the --project argument and only create projects relevant for the test execution. This avoids the need for a fully configured env if only running a certain test set. Part of eclipse-glsp/glsp#1154
tortmayr
added a commit
to eclipse-glsp/glsp-playwright
that referenced
this issue
Mar 2, 2024
- Add workflow for executing playwright tests for a dedicated GLSP component/project - Adapt playwright config to also report via `github-actions-repoter` when executed in a CI env - Adapt playwright config to consider the --project argument and only create projects relevant for the test execution. This avoids the need for a fully configured env if only running a certain test set. Part of eclipse-glsp/glsp#1154
tortmayr
added a commit
to eclipse-glsp/glsp-playwright
that referenced
this issue
Mar 3, 2024
# GLSP-1179 - Update tsconfig, eslint config and package.json to fully utilize composite typescript/eslint builds -- Compile typescript code from root instead of streaming to each package -- Remove lint and clean from prepare steps. Linting is the most expensive step and is already covered via vscode/ci. Manual execution is enough. Skipping the clean step per default ensures that we can fully utilize incremental ts builds -- Adapt linting commands to be executed with a single command from root instead of streaming to all packages Part of eclipse-glsp/glsp#1179 # GLSP 1154 - Update project configuration to also create projects for testing against firefox/edge if the MULTI_BROWSER env variable is set to true - Update to playwright 1.42.1. This is necessary to allow passing regexes/wildcards for the --project argument - Also report with `estruyf/github-actions-reporter` when running in CI Part of eclipse-glsp/glsp#1154
tortmayr
added a commit
to eclipse-glsp/glsp-playwright
that referenced
this issue
Mar 3, 2024
# GLSP-1179 - Update tsconfig, eslint config and package.json to fully utilize composite typescript/eslint builds -- Compile typescript code from root instead of streaming to each package -- Remove lint and clean from prepare steps. Linting is the most expensive step and is already covered via vscode/ci. Manual execution is enough. Skipping the clean step per default ensures that we can fully utilize incremental ts builds -- Adapt linting commands to be executed with a single command from root instead of streaming to all packages Part of eclipse-glsp/glsp#1179 # GLSP 1154 - Update project configuration to also create projects for testing against firefox/edge if the MULTI_BROWSER env variable is set to true - Update to playwright 1.42.1. This is necessary to allow passing regexes/wildcards for the --project argument - Also report with `estruyf/github-actions-reporter` when running in CI Part of eclipse-glsp/glsp#1154
Will be tracked in #1287 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Now as we have a nice Playwright page object library, let's create / run end-to-end tests for all features of the Workflow example on every change of glsp-client, glsp-server, and the integration repos.
The integration code and tests can remain in the glsp-playwright repository.
The text was updated successfully, but these errors were encountered: