GLSP-1408: Make live validation asynchronous #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that I opted for the status message as it is less intrusive as the progress message. However, there can only ever be a single status message at a time so it might not be the right choice in all cases. I'm happy to discuss this. @ivy-lli FYI as well |
ivy-lli
approved these changes
Oct 18, 2024
|
@tortmayr I'll merge this for now and if you do not have any objections, I'll double check the Node server to behave the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
eclipse-glsp/glsp#1408
How to test
Follow-ups
Changelog