Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Curie enumeration fails in SAMM SDK 2.3.1 #259

Closed
tom-rm-meyer-ISST opened this issue Oct 19, 2023 · 4 comments
Closed

[BUG] Curie enumeration fails in SAMM SDK 2.3.1 #259

tom-rm-meyer-ISST opened this issue Oct 19, 2023 · 4 comments
Labels
acknowledged Has been viewed by one of the maintainers and is ready for further work, discussion or other steps. bug Something isn't working

Comments

@tom-rm-meyer-ISST
Copy link

Describe the bug
The model in this PR uses a curie for enumeration which validates fine in aspect model editor v 4.5.2.

See validation in this github action run.

Where
See stage "Validate semantic models":

Starting download of SAMM SDK v2.3.1
Downloaded SAMM SDK v2.3.1
Validating TTL file io.catenax.shared.quantity/1.0.0/Quantity.ttl
[
{
file: 'io.catenax.shared.quantity/1.0.0/Quantity.ttl',
response: 'Validation failed:\n' +
'Validation succeeded, but an error was found while processing the model. This indicates an error in the model validation; please consider reporting this issue including the model at https://github.com/eclipse-esmf/esmf-semantic-aspect-meta-model/issues -- Could not load Aspect model, please make sure the model is valid: Literal can not be parsed: unit:piece^^urn:samm:org.eclipse.esmf.samm:meta-model:2.0.0#curie\n' +
'\n'
}
]

Screenshots
not applicable

Additional context
An enumeration with curie is used to allow different types of units of measure.

@chris-volk
Copy link
Contributor

Hi @tom-rm-meyer-ISST ,
I created a bug in the sdk repository: eclipse-esmf/esmf-sdk#454 .

When you identify bugs in the SDK, please use that repository if possible (unless it is clear that the SAMM specification or its SHACL shapes themselves are the originator of the improvement/bug)

@chris-volk chris-volk closed this as not planned Won't fix, can't repro, duplicate, stale Oct 19, 2023
@chris-volk
Copy link
Contributor

Hi @tom-rm-meyer-ISST , I created a bug in the sdk repository: eclipse-esmf/esmf-sdk#454 .

When you identify bugs in the SDK, please use that repository if possible (unless it is clear that the SAMM specification or its SHACL shapes themselves are the originator of the improvement/bug)

Never mind, I have now read the message and this is exactly the case. thanks for reporting it in samm.

@chris-volk chris-volk reopened this Oct 19, 2023
@tom-rm-meyer-ISST
Copy link
Author

Hi @tom-rm-meyer-ISST , I created a bug in the sdk repository: eclipse-esmf/esmf-sdk#454 .

When you identify bugs in the SDK, please use that repository if possible (unless it is clear that the SAMM specification or its SHACL shapes themselves are the originator of the improvement/bug)

Never mind, I have now read the message and this is exactly the case. thanks for reporting it in samm.

I blindly followed the hint in the GitHub action. Therefore: thanks for emphasizing!

@chris-volk chris-volk added the acknowledged Has been viewed by one of the maintainers and is ready for further work, discussion or other steps. label Oct 24, 2023
@ysrbo
Copy link
Contributor

ysrbo commented Jan 3, 2024

was fixed in sdk#382

@atextor atextor closed this as completed Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledged Has been viewed by one of the maintainers and is ready for further work, discussion or other steps. bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants