Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding capability to support PKI #509

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

JavaJoeS
Copy link

@JavaJoeS JavaJoeS commented May 2, 2024

Update with option to install PKI from marketplace, org.eclipse.core.pki

Comment on lines 109 to 110
// TODO Auto-generated catch block
e.printStackTrace();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use ILog.log().error(e.getMessage(), e)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mickaelistria I noticed that most of the other try catch blocks just throw and dont print anything out. There are no other ILog messages in that bundle. Maybe better to stick with the picture show and just throw?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mickaelistria Looking again, the software is supposed to be transparent and not required, so perhaps btter to not do anything in the catch block. Software does not even need to know an exception may have occurred.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please 🙏 try to keep a PR to a single commit. Amend and force push further changes. Then you won’t be asked to squash the commits later.

Copy link

github-actions bot commented May 11, 2024

Test Results

  375 files  +366    375 suites  +366   41m 4s ⏱️ + 8m 42s
1 893 tests  - 304  1 890 ✅  - 303  3 💤  - 1  0 ❌ ±0 
6 679 runs   -   2  6 670 ✅ ±  0  9 💤  - 2  0 ❌ ±0 

Results for commit 2c2b5bc. ± Comparison against base commit c9f0582.

This pull request removes 2165 and adds 1861 tests. Note that renamed tests count towards both.
org.eclipse.equinox.frameworkadmin.tests.Bug196525 ‑ testConfigContent
org.eclipse.equinox.frameworkadmin.tests.Bug258370 ‑ testComma
org.eclipse.equinox.frameworkadmin.tests.CleanupTest ‑ testOSGiRemoval
org.eclipse.equinox.frameworkadmin.tests.CleanupTest ‑ testSimpleConfiguratorRemoval
org.eclipse.equinox.frameworkadmin.tests.CleanupTest ‑ testWithMutipleBundles
org.eclipse.equinox.frameworkadmin.tests.FrameworkExtensionTest ‑ testAddRemoveFrameworkExtension
org.eclipse.equinox.frameworkadmin.tests.LauncherConfigLocationTest ‑ testCustomLauncherConfig
org.eclipse.equinox.frameworkadmin.tests.LauncherDataTest ‑ testRemoveProgramArg
org.eclipse.equinox.frameworkadmin.tests.ManipulatorTests ‑ testBug212361_osgiInBundlesList
org.eclipse.equinox.frameworkadmin.tests.ManipulatorTests ‑ testBug258126_ProgramArgs_VMArgs
…
AutomatedTests org.eclipse.equinox.frameworkadmin.tests.AllTests org.eclipse.equinox.frameworkadmin.tests.Bug196525 ‑ testConfigContent
AutomatedTests org.eclipse.equinox.frameworkadmin.tests.AllTests org.eclipse.equinox.frameworkadmin.tests.Bug258370 ‑ testComma
AutomatedTests org.eclipse.equinox.frameworkadmin.tests.AllTests org.eclipse.equinox.frameworkadmin.tests.CleanupTest ‑ testOSGiRemoval
AutomatedTests org.eclipse.equinox.frameworkadmin.tests.AllTests org.eclipse.equinox.frameworkadmin.tests.CleanupTest ‑ testSimpleConfiguratorRemoval
AutomatedTests org.eclipse.equinox.frameworkadmin.tests.AllTests org.eclipse.equinox.frameworkadmin.tests.CleanupTest ‑ testWithMutipleBundles
AutomatedTests org.eclipse.equinox.frameworkadmin.tests.AllTests org.eclipse.equinox.frameworkadmin.tests.FrameworkExtensionTest ‑ testAddRemoveFrameworkExtension
AutomatedTests org.eclipse.equinox.frameworkadmin.tests.AllTests org.eclipse.equinox.frameworkadmin.tests.LauncherConfigLocationTest ‑ testCustomLauncherConfig
AutomatedTests org.eclipse.equinox.frameworkadmin.tests.AllTests org.eclipse.equinox.frameworkadmin.tests.LauncherDataTest ‑ testRemoveProgramArg
AutomatedTests org.eclipse.equinox.frameworkadmin.tests.AllTests org.eclipse.equinox.frameworkadmin.tests.ManipulatorTests ‑ testBug212361_osgiInBundlesList
AutomatedTests org.eclipse.equinox.frameworkadmin.tests.AllTests org.eclipse.equinox.frameworkadmin.tests.ManipulatorTests ‑ testBug258126_ProgramArgs_VMArgs
…
This pull request removes 4 skipped tests and adds 3 skipped tests. Note that renamed tests count towards both.
org.eclipse.equinox.p2.tests.importexport.ImportExportRemoteTests ‑ Unknown test
org.eclipse.equinox.p2.tests.touchpoint.natives.CheckAndPromptNativePackageWindowsRegistryTest ‑ Unknown test
org.eclipse.equinox.p2.tests.ui.dialogs.EECompatibilityTest ‑ testEEIssueSkipsRemediation
org.eclipse.equinox.p2.tests.ui.dialogs.EECompatibilityTest ‑ testSingleIUPreventInstallation
AutomatedTests org.eclipse.equinox.p2.tests.ui.dialogs.AllTests org.eclipse.equinox.p2.tests.ui.dialogs.EECompatibilityTest ‑ testEEIssueSkipsRemediation
AutomatedTests org.eclipse.equinox.p2.tests.ui.dialogs.AllTests org.eclipse.equinox.p2.tests.ui.dialogs.EECompatibilityTest ‑ testSingleIUPreventInstallation
org.eclipse.equinox.p2.tests.importexport.AllTests ‑ org.eclipse.equinox.p2.tests.importexport.ImportExportRemoteTests

♻️ This comment has been updated with latest results.

@JavaJoeS
Copy link
Author

@mickaelistria Please recheck..

@laeubi
Copy link
Member

laeubi commented May 11, 2024

Update with option to install PKI from marketplace, org.eclipse.core.pki

I must confess I can't connect that statement to the actual code, the code seem to enable useJREHttp if the default SSL context contains TLS (what else could it be), how is this connected to org.eclipse.core.pki? Why is this doen with P2 transport directly and not with ECF where the actual connection is made?

@JavaJoeS
Copy link
Author

@laeubi When there is no PKI enabled the default SSLContext is not TLS.

Copy link
Member

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase, squash commits and add documentation somewhere why / what this change does, forcing JRE http does not look "right" just because TLS is enabled (?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants