Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VersionRange for root features is too tight when expanded version given #507

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Apr 29, 2024

Currently the (disabled by default) requirement for a root feature uses an exact version range when the feature version is expanded (e.g. Tycho) but the purpose of a root feature is that it can be updated what such a strict range makes it impossible (if activated).

This now adds a new IVersionRangeAdvice that allows to modify the result of a product included requirements version range.

@laeubi laeubi requested a review from merks April 29, 2024 05:50
Copy link

github-actions bot commented Apr 29, 2024

Test Results

    9 files  ±0      9 suites  ±0   29m 47s ⏱️ -30s
2 196 tests ±0  2 192 ✅ ±0   4 💤 ±0  0 ❌ ±0 
6 678 runs  ±0  6 667 ✅ ±0  11 💤 ±0  0 ❌ ±0 

Results for commit 0424619. ± Comparison against base commit 4426f86.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

I questioned if we should upper bound with the next major version, but I do feature really respect semantic versioning and even if they do, what safety would this really buy us? So I think only a lower bound is okay.

@laeubi
Copy link
Member Author

laeubi commented Apr 29, 2024

I think the best would be if one can configure it in the product editor like it is possible with feature dependencies, this would probably be even better than the current "root feature" approach. But that's more for a future enhancement.

Currently the (disabled by default) requirement for a root feature uses
an exact version range when the feature version is expanded (e.g. Tycho)
but the purpose of a root feature is that it can be updated what such a
strict range makes it impossible (if activated).

This now adds a new IVersionRangeAdvice that allows to modify the result
of a product included requirements version range.
@laeubi laeubi merged commit c9f0582 into eclipse-equinox:master Apr 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants