Remove processing of unused plugin element attributes in feature.xml and distinction between Plug-ins and Fragments in ProductFile #368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of two parts:1. Remove unused distinction between Plug-ins and Fragments inProductFile
There is no usage of a product's fragments in P2 or PDE.
Consequently PDE support for adding a
fragment
attribute for fragments listed in a product file can be removed too.Remove processing of unused plugin element attributes in
feature.xml
Which happens in the context of eclipse-pde/eclipse.pde#730
From the removed attributes only the unpack attribute has been considered in in the
FeaturesAction
and theRemoteFeaturesAction
in order to create correspondingBundleShapeAdvice
.But at least for Tycho those advies did not have any effect.
I assume, but I haven't verified it, that
BundleShapeAdvices
might have an effect in PDE-build tasks. But since a bundle itself should specify its bundle-shape in its MANIFEST.MF I'm fine with removing that support from PDE with this.Nevertheless it requires some rework of the PDE-builds task since they use
FeatureEntry.isUnpack()/unpackSet()/...
, therefore this is currently a draft.