Make CompoundQueryable(Collection) constructor public #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
reviewed
Sep 26, 2023
| // don't suppress the warning as it will cause warnings in the official build | ||
| // see bug 423628. Write this without unchecked conversion. | ||
| this(queryables.toArray(new IQueryable[queryables.size()])); | ||
| this.queryables = (Collection<IQueryable<T>>) queryables; |
There was a problem hiding this comment.
why not make the filed of the same type? Also the previous code has made a copy of the collection, so List.copyOf( ... ) would also solve your issue here without a cast.
There was a problem hiding this comment.
Good suggestions. Applied them both.
A copy is not necessary in all cases, but often a List.of() is passed any way, which is only passed through List.copyOf().
HannesWell
force-pushed
the
compoundQueryableConstructor
branch
from
a439878
to
db2a461
Compare
|
I added a second commit to add a similar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.