Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue 2211 #2289

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for issue 2211 #2289

wants to merge 2 commits into from
+36 −8

Conversation

ajaypaul-ibm
Copy link
Contributor

This PR contains a fix for issue #2211. The query now correctly includes all primary keys instead of just one.

@rfelcman
Copy link
Contributor

Sorry this fix can't be accepted as tests
EclipseLink PR build / Test on JDK 21 (pull_request) continuous-integration/jenkins/pr-merge are not passing please search test log outputs and modify Your code.

rfelcman
rfelcman requested changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@rfelcman rfelcman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing there tests. See mainly JUnitJPQLFunctionsTest.java or with this alias generation JUnitJPQLJakartaDataNoAliasTest.java

@ajaypaul-ibm
Copy link
Contributor Author

Hi @rfelcman
We have a few questions regarding this issue and have sent you an email with the details. Whenever you have a chance, could you kindly take a look?
Thank you very much for your time and help!

@ajaypaul-ibm
Copy link
Contributor Author

ajaypaul-ibm commented Nov 12, 2024 •
edited
Loading

Hi @rfelcman I went through the mail. Is @IdClass is not supported in EclipseLink?

@rfelcman
Copy link
Contributor

Hi @rfelcman I went through the mail. Is @IdClass is not supported in EclipseLink?

Of course @IdClass it's supported in EclipseLink. Simply search code. You will find there a lot of examples in the tests. It just doesn't work with JPQL function ID() with multiple @Ids.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfelcman rfelcman rfelcman requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajaypaul-ibm @rfelcman