API Key in app.config.json ignored

[siskavera]

Bug Report

Describe the Bug

The API Key configured in app.config.json seems to be ignored and is instead taken exclusively from the environment config (e.g. environment.prod.ts).

Expected Behavior

API Key configured in app.config.json is used by the frontend.

Observed Behavior

API Key from the environment config (e.g. environment.prod.ts) is used, even if there is a different value configured in app.config.json.

Steps to Reproduce

Steps to reproduce the behavior:

1. Configure an API key in app.config.json that is different from the one in the environment config
2. Run the application
3. Observe the headers sent with any request
4. See that the value of the "X-Api-Key" header contains the API key configured in the environment config.

Context Information

There is an existing "TODO" in the code at line 83 of app.module.ts, but I haven't found a corresponding issue.

Possible Implementation

The value in the environment file could be taken as a default, overwritten by the app config if it is configured there.

[janpmeyer]

Hey,

did you use it in combination with the MVD?

[veronikasiska]

Yes, I did

Hey,

did you use it in combination with the MVD?

[janpmeyer]

Did you change it in the DataDashboard Config or in the MinimumViableDataspace Repo?

Bc the DataDashboard Configs are in the MVD Repo if you try to change sth.

For each company their is an own config. For example company1

[veronikasiska]

Hi, I changed it in the MVD repo. My issue was half a year ago though and I ended up using a workaround, because from the comment on line 81 in app.module.ts in the DataDashboard repo:

      provide: HTTP_INTERCEPTORS, multi: true, useFactory: () => {
        let i = new EdcApiKeyInterceptor();
        // TODO: read this from app.config.json??
        i.apiKey = environment.apiKey
        return i;
      }, deps: [AppConfigService]
    },

it looked like it just wasn't implemented to take a different API key.

I double-checked and the code-block still looks the same today on the main branch.