Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add images used in internal samples as RELATED_IMAGES variables into the che-operator container #23149

Closed
svor opened this issue Sep 16, 2024 · 6 comments
Assignees
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed. team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che

Comments

@svor
Copy link
Contributor

svor commented Sep 16, 2024

Is your task related to a problem? Please describe

Currently it's hard to collect all related images that should be pre-pull

Describe the solution you'd like

All images that used in editors' definitions and internal samples' devfiles should be added as environment variables into the operator container to pre-pull them.

Currently we only have env variables that describe related images used in editors: RELATED_IMAGE_editor_definition_che_code_latest_che_code_runtime_description=registry.redhat.io/devspaces/udi-rhel8@sha256:9199796c9dd82a16ebb2c4ff8d06b9727f392eb93eb7ffa2974ad6c16e3d8e5d

Need similar variables for images used in samples:
RELATED_IMAGE_sample_devfile_ansible_devspaces_demo=ghcr.io/ansible/ansible-workspace-env-reference@sha256:03d7f0fe6caaae62ff2266906b63d67ebd9cf6e4a056c7c0a0c1320e6cfbebce

Describe alternatives you've considered

No response

Additional context

No response

@svor svor added kind/task Internal things, technical debt, and to-do tasks to be performed. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che labels Sep 16, 2024
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 16, 2024
@svor svor removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 16, 2024
@tolusha
Copy link
Contributor

tolusha commented Sep 17, 2024

To find out the list of samples:
http://che-dashboard.eclipse-che.svc:8080/dashboard/api/airgap-sample

To find out the list of editors:
http://che-dashboard.eclipse-che.svc.cluster.local:8080/dashboard/api/editors

@ibuziuk
Copy link
Member

ibuziuk commented Sep 17, 2024

@tolusha is it documented by any chance?

@tolusha
Copy link
Contributor

tolusha commented Sep 19, 2024

Operators should:

  1. reads the list of samples and editors from the dashboard using internal urls, parses and grabs images.
  2. uses those images to configure imagepuller operator
  3. stores them in /tmp/external_images.txt file

Document how to read that file by admin

@ibuziuk
Copy link
Member

ibuziuk commented Sep 26, 2024

@tolusha looks like there is some mismatch with images based on:

sh-5.1# env | grep ^RELATED_IMAGE_editor_definition_
RELATED_IMAGE_editor_definition_che_idea_latest_idea_rhel8_injector=registry.redhat.io/devspaces/idea-rhel8@sha256:0286c708c10dc4740f3e7c70f79b7c6976d63e069ee4a4380004bdbe77ff7e05
RELATED_IMAGE_editor_definition_che_code_latest_che_code_injector=registry.redhat.io/devspaces/code-rhel8@sha256:007bc86b63ddc948be828536bc0a6b7dbaeee3d272287f62f2336009e7b9c6a0
RELATED_IMAGE_editor_definition_che_code_latest_che_code_runtime_description=registry.redhat.io/devspaces/udi-rhel8@sha256:9199796c9dd82a16ebb2c4ff8d06b9727f392eb93eb7ffa2974ad6c16e3d8e5d
RELATED_IMAGE_editor_definition_che_idea_latest_idea_rhel8=registry.redhat.io/devspaces/udi-rhel8@sha256:9199796c9dd82a16ebb2c4ff8d06b9727f392eb93eb7ffa2974ad6c16e3d8e5d

last idea image point to UDI for some reason

@ibuziuk
Copy link
Member

ibuziuk commented Sep 26, 2024

N.B. api/airgap-sample does not provide the image information

@tolusha
Copy link
Contributor

tolusha commented Oct 1, 2024

That's because upstream doesn't have any samples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed. team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che
Projects
Status: ✅ Done
Development

No branches or pull requests

4 participants