Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminals created via "New terminal (Select a container)" have incorrect wrapping until the window is resized #22584

Open
amisevsk opened this issue Oct 5, 2023 · 2 comments · Fixed by eclipse-che/che-machine-exec#277
Assignees
Labels
area/editor/vscode Issues related to the Code OSS editor of Che area/editors area/machine-exec severity/P3 Lower priority than a P2. Optional work that might get done, or not. See also help wanted issues. team/B This team is responsible for the Web Terminal, the DevWorkspace Operator and the IDEs.

Comments

@amisevsk
Copy link
Contributor

amisevsk commented Oct 5, 2023

Describe the bug

Terminals created through "New Terminal (Select a container)" appear to be created with the default width (80 characters?). This results in incorrect handling of text, with lines longer than 80 characters breaking the terminal. If the browser window is resized, it appears that the correct dimensions are sent to the terminal, and it begins behaving normally.

Che version

7.75@latest

Steps to reproduce

  1. Start a workspace
  2. Open a terminal by navigating Terminal -> New Terminal (Select a Container)
  3. Type a line longer than 80 characters -> text wraps back to beginning of line, overwriting earlier text
  4. Resize the browser window
  5. Terminal behaves as expected

Expected behavior

Terminals created through "New Terminal (Select a Container)" should behave the same as terminals created through "New Terminal"

Runtime

OpenShift

Screenshots

terminal-wrap-che

Installation method

OperatorHub

Environment

Linux

Eclipse Che Logs

No response

Additional context

No response

@amisevsk amisevsk added kind/bug Outline of a bug - must adhere to the bug report template. area/machine-exec area/editors area/editor/vscode Issues related to the Code OSS editor of Che labels Oct 5, 2023
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 5, 2023
@l0rd l0rd added severity/P1 Has a major impact to usage or development of the system. team/B This team is responsible for the Web Terminal, the DevWorkspace Operator and the IDEs. and removed kind/bug Outline of a bug - must adhere to the bug report template. status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Oct 9, 2023
@amisevsk amisevsk self-assigned this Nov 24, 2023
@amisevsk amisevsk reopened this Jan 30, 2024
@amisevsk
Copy link
Contributor Author

Reopening issue as there are lingering problems with terminal width -- Code seems to compute character width incorrectly in many cases, with the number of columns changing after the terminal has been initialized (you can see this by changing e.g. the font size for the terminal: eclipse-che/che-machine-exec#277 (comment))

@ibuziuk ibuziuk assigned AObuchow and unassigned amisevsk Jan 31, 2024
@ibuziuk
Copy link
Member

ibuziuk commented May 17, 2024

@azatsarynnyy @RomanNikitenko folks, any ideas about this issue? can we raise it on code-oss end?

@ibuziuk ibuziuk added severity/P3 Lower priority than a P2. Optional work that might get done, or not. See also help wanted issues. and removed severity/P1 Has a major impact to usage or development of the system. labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/vscode Issues related to the Code OSS editor of Che area/editors area/machine-exec severity/P3 Lower priority than a P2. Optional work that might get done, or not. See also help wanted issues. team/B This team is responsible for the Web Terminal, the DevWorkspace Operator and the IDEs.
Development

Successfully merging a pull request may close this issue.

5 participants