Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options for format_value() : drop leading 0, minus and plus signs #724

Merged
merged 9 commits into from
Feb 22, 2023

Conversation

strengejacke
Copy link
Member

Fixes #711

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2023

Codecov Report

Merging #724 (008bced) into main (baead01) will increase coverage by 0.04%.
The diff coverage is 85.71%.

❗ Current head 008bced differs from pull request most recent head 745df6b. Consider uploading reports for the commit 745df6b to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #724      +/-   ##
==========================================
+ Coverage   51.77%   51.82%   +0.04%     
==========================================
  Files         125      125              
  Lines       14802    14818      +16     
==========================================
+ Hits         7664     7679      +15     
- Misses       7138     7139       +1     
Impacted Files Coverage Δ
R/format_number.R 68.29% <66.66%> (ø)
R/format_value.R 72.50% <88.88%> (+3.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@strengejacke strengejacke merged commit 8d64ef8 into main Feb 22, 2023
@strengejacke strengejacke deleted the strengejacke/issue711 branch February 22, 2023 13:00
@bwiernik
Copy link
Contributor

Awesome thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

options for format_value() : drop leading 0, minus and plus signs
3 participants