Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data_rename() doesn't accept empty replacement anymore #539

Merged
merged 6 commits into from
Sep 11, 2024
Merged

data_rename() doesn't accept empty replacement anymore #539

merged 6 commits into from
Sep 11, 2024

Conversation

strengejacke
Copy link
Member

No description provided.

@strengejacke strengejacke mentioned this pull request Sep 9, 2024
Merged
etiennebacher
etiennebacher requested changes Sep 9, 2024
View reviewed changes
R/data_rename.R Outdated Show resolved Hide resolved
etiennebacher
etiennebacher reviewed Sep 9, 2024
View reviewed changes
Copy link
Member

@etiennebacher etiennebacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM except for one error message to clarify but apart from that feel free to merge

NEWS.md Outdated Show resolved Hide resolved
R/data_rename.R Outdated Show resolved Hide resolved
@etiennebacher etiennebacher changed the title Update argument data_rename() doesn't accept empty replacement anymore Sep 9, 2024
@etiennebacher etiennebacher merged commit a1fe5f8 into main Sep 11, 2024
20 of 22 checks passed
@etiennebacher etiennebacher deleted the use_new_arg branch September 11, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etiennebacher etiennebacher etiennebacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strengejacke @etiennebacher