data_rename() works with named vector #538
Conversation
| expect_named( | ||
| data_rename(test, c(length = "Sepal.Length", width = "Sepal.Width")), | ||
| c("length", "width", "Petal.Length", "Petal.Width", "Species") | ||
| ) |
There was a problem hiding this comment.
Looks good to me, can you add a test about what happens when someone passes a partially named vector, e.g. data_rename(test, c(length = "Sepal.Length", "Sepal.Width"))? I suppose it would error but I just want to ensure it throws a nice error message.
Same thing for the case where the user passes a named vector and a replacement, e.g. data_rename(test, c(length = "Sepal.Length"), replacement = "Sepal.Width")
There was a problem hiding this comment.
First example will remove column name, second will ignore replacement. First example is in line with the current behaviour:
data_rename(iris, c("Sepal.Length", "Sepal.Width"), replacement = c("aaa", ""))
For the second case, I have made this more explicit in the docs.
No description provided.