Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CRAN errors #525

Merged
merged 3 commits into from
Jul 14, 2024
Merged

Fix CRAN errors #525

merged 3 commits into from
Jul 14, 2024

Conversation

strengejacke
Copy link
Member

@strengejacke
Copy link
Member Author

@etiennebacher Sorry, we didn't manage to fix the errors on CRAN... By adding the NOTE, I forgot to include the htmltools package. So we still don't have binaries for OS X.

etiennebacher
etiennebacher approved these changes Jul 14, 2024
View reviewed changes
Copy link
Member

@etiennebacher etiennebacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it's weird that this wasn't caught in any of the workflows we have though. I'll make a patch release tonight or tomorrow

@etiennebacher etiennebacher merged commit f247fb0 into main Jul 14, 2024
21 of 22 checks passed
@etiennebacher etiennebacher deleted the fix_vignette branch July 14, 2024 18:58
@etiennebacher etiennebacher mentioned this pull request Jul 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etiennebacher etiennebacher etiennebacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strengejacke @etiennebacher