Fix to_numeric() with inversed factor levels

[strengejacke]

See also easystats/insight#835

[codecov]

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (2852033) 89.09% compared to head (e798cfb) 89.10%.

Files	Patch %	Lines
R/data_tabulate.R	54.54%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
+ Coverage   89.09%   89.10%   +0.01%     
==========================================
  Files          72       72              
  Lines        5409     5414       +5     
==========================================
+ Hits         4819     4824       +5     
  Misses        590      590              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[etiennebacher]

Thanks

[strengejacke]

Once you change one or two files, there's a chain reaction of lintrs you have to fix ;-)
Waiting for checks to finish.

[strengejacke]

Behaviour is now in line with table(as.numeric()):

library(datawizard)
f <- c(0, 0, 1, 1, 1, 0, 1)
x1 <- factor(f, levels = c(0, 1))
x2 <- factor(f, levels = c(1, 0))

table(as.numeric(x1))
#> 
#> 1 2 
#> 3 4
out <- to_numeric(x1, dummy_factors = FALSE, preserve_levels = FALSE)
table(out)
#> out
#> 1 2 
#> 3 4

table(as.numeric(x2))
#> 
#> 1 2 
#> 4 3
out <- to_numeric(x2, dummy_factors = FALSE, preserve_levels = FALSE)
table(out)
#> out
#> 1 2 
#> 4 3

^{Created on 2023-11-27 with reprex v2.0.2}