-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install EasyBuild as a module in base image + clean up GCC 9.3.0 image #8
Conversation
@@ -4,11 +4,13 @@ ARG EB_VER=4.2.1 | |||
LABEL easybuild_version=${EB_VER} | |||
# install required packages (EPEL is required for Lmod) | |||
RUN yum install -y epel-release \ | |||
&& yum install -y bzip2 file gcc-c++ git Lmod make openssl-devel patch python3-pip unzip vim which | |||
&& yum install -y bzip2 file gcc-c++ git Lmod make openssl openssl-devel patch python3-pip unzip vim which rdma-core-devel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we install rdma-core-devel here? Who is to say someone wants to run RDMA stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having rdma-core-devel
installed affects how OpenMPI is configured (--with-verbs
or --without-verbs
).
I'm happy to remove it, it's probably overkill here, but I don't think it hurts to have it installed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just wonder if we need to install this in the base - but ok... premature optimization I'd say
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, I don't think it hurts much, except for size of the container a little bit?
Stripping it out is not a huge deal for the tutorial, and if it's there you can add rdma-core-devel
in another image on top of this one, and rebuild OpenMPI
(and everything that depends on it...), if you really want IB support, but that's a hassle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's keep it for now... and put a pin in it for a later discussion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open an issue on it in this repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
&& ml --version \ | ||
&& which -a eb \ | ||
&& eb --version \ | ||
&& eb --show-system-info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beautiful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
&& eb --show-system-info | ||
# remove globally installed EasyBuild, we can use the module going forward | ||
USER root | ||
RUN pip3 uninstall -y easybuild |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
potential optimization #11
No description provided.