Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename custom easyblock parameters #3361

Open
jfgrimm opened this issue Jun 13, 2024 · 1 comment
Open

rename custom easyblock parameters #3361

jfgrimm opened this issue Jun 13, 2024 · 1 comment
Labels
EasyBuild-5.0 EasyBuild 5.0
Milestone

Comments

@jfgrimm
Copy link
Member

jfgrimm commented Jun 13, 2024

We should go through all the easyblocks to check what custom parameters they define, and ensure those also adhere to our naming policy (see easybuilders/easybuild-framework#4563)

@jfgrimm jfgrimm added the EasyBuild-5.0 EasyBuild 5.0 label Jun 13, 2024
@jfgrimm jfgrimm added this to the 5.0 milestone Jun 13, 2024
@Flamefire
Copy link
Contributor

Experience from trying to change testinstall to install_for_test in PythonPackage used by PythonBundle:

  • PythonBundle tries to set self.cfg['exts_default_options'][key] = self.cfg[key] with key = install_for_test
  • The decorator on __get_item__ changes the key to testinstall
  • This doesn't exist in PythonBundle (inheriting vars from PythonPackage)
  • --> Error "Use of unknown easyconfig parameter 'testinstall' when getting parameter value"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EasyBuild-5.0 EasyBuild 5.0
Projects
None yet
Development

No branches or pull requests

2 participants