You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently there are several ad-hoc checks for incompatible combinations of parameters, such as:
ERA5-land is not compatible with the preliminary back extension
statistics option is ignored if ensemble is False
variable names must match the table (e.g. snow_cover only accepted if --land==True)
for monthly data there is a check for missing vars
etc.
This leads to double checking and unclear state (can we assume .... at this place in the code?) and at the same time several incompatible combinations may silently pass.
It would be good to check validate the input on initialization of the Fetch class. There it will verify both the CLI or API input. Then in the rest of the code we can assume valid input.
The text was updated successfully, but these errors were encountered:
Currently there are several ad-hoc checks for incompatible combinations of parameters, such as:
This leads to double checking and unclear state (can we assume .... at this place in the code?) and at the same time several incompatible combinations may silently pass.
It would be good to check validate the input on initialization of the Fetch class. There it will verify both the CLI or API input. Then in the rest of the code we can assume valid input.
The text was updated successfully, but these errors were encountered: