Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing thread include #87

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -144,10 +144,7 @@ jobs:
# TSAN

tsan:
# NOTE: there is a known issue in TSAN 20.04 with std::condition_variable::wait_for
# https://github.com/google/sanitizers/issues/1259
# Until this is fixed, we use 20.04 for TSAN work
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
steps:

- name: Sync repository
Expand All @@ -158,7 +155,7 @@ jobs:
- name: Download dependencies and install requirements
uses: ./src/.github/actions/project_dependencies
with:
os: ubuntu-20.04
os: ubuntu-22.04
cmake_build_type: Release
dependencies_artifact_postfix: ${{ github.event.inputs.dependencies_artifact_postfix || env.default_dependencies_artifact_postfix }}
secret_token: ${{ secrets.GITHUB_TOKEN }}
Expand Down
1 change: 1 addition & 0 deletions cpp_utils/test/unittest/return_code/ReturnCodeTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
// limitations under the License.

#include <algorithm>
#include <thread>

#include <cpp_utils/testing/gtest_aux.hpp>
#include <gtest/gtest.h>
Expand Down
2 changes: 2 additions & 0 deletions cpp_utils/test/unittest/thread_pool/slot_thread_pool_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
// See the License for the specific language governing permissions and
// limitations under the License.

#include <thread>

#include <cpp_utils/testing/gtest_aux.hpp>
#include <gtest/gtest.h>

Expand Down
Loading