Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rosdep gtest #33

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix rosdep gtest #33

wants to merge 1 commit into from

Conversation

artivis
Copy link

@artivis artivis commented Jan 18, 2023

Fix rosdep googletest-distribution -> gtest : (rosdep/base)

jparisu
jparisu previously approved these changes Jan 19, 2023
Copy link
Contributor

@jparisu jparisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@artivis artivis temporarily deployed to codecov January 19, 2023 07:21 — with GitHub Actions Inactive
@jparisu
Copy link
Contributor

jparisu commented Jan 19, 2023

Please @artivis rebase this branch to current main. The PRs that have been merged in between does not affect these changes so rebase should be easy and clean.

@artivis artivis temporarily deployed to codecov January 19, 2023 07:24 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2023

Codecov Report

Base: 71.51% // Head: 71.51% // No change to project coverage 👍

Coverage data is based on head (4785d52) compared to base (022553d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage   71.51%   71.51%           
=======================================
  Files          50       50           
  Lines         853      853           
  Branches      202      202           
=======================================
  Hits          610      610           
  Misses        134      134           
  Partials      109      109           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: artivis <[email protected]>
@artivis
Copy link
Author

artivis commented Jan 19, 2023

Please @artivis rebase this branch to current main.

Done.

@artivis artivis temporarily deployed to codecov February 2, 2023 07:19 — with GitHub Actions Inactive
@artivis artivis temporarily deployed to codecov February 2, 2023 07:19 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants